chore: update READMEs and make testing more resilient on OSX #9275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unneeded reliance on testutil for running simple commands as that package's init mechanism tries to communicate with Docker
Badger has its own repo and test scripts
Add more narrative; instructions for testing on OSX
matthewmcneely
requested review from
johnymontana,
mangalaman93 and
ryanfoxtyler
github-actions
bot
added
area/testing
commit 408e064 Author: Ryan Fox-Tyler <[email protected]> Date: Wed Jan 15 06:35:35 2025 -0800 chore: init trunk (#9273) **Description** Initializing Trunk for formatting and linting across the repo **Checklist** - [X] Code compiles correctly and linting passes locally commit ee60263 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed Jan 15 13:23:32 2025 +0530 chore(deps): Update go minor and patch (#9267) commit 02b9d13 Author: Harshil Goel <[email protected]> Date: Mon Jan 13 18:31:26 2025 +0530 fix(core): change name of config flag for cache (#9274) commit ee99a7a Author: Harshil Goel <[email protected]> Date: Mon Jan 13 14:16:40 2025 +0530 perf(core): Fixing ristretto cache to pass jepsen tests (#9237)
|
Deleting in favor of correctly rebased branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the CONTRIBUTING and t/README files with more correct instructions on Dgraph testing, as well as instructions on how to test on OSX.
Additionally, updates to the Makefile give more visibility to the build process and other changes needed for more up-to-date functionality.
Checklist