perf(core): Fixing ristretto cache to pass jepsen tests #9237
+411
−194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/testing
harshil-goel
force-pushed
the
harshil-goel/cache-new
branch
2 times, most recently
from
3f371a2 to
2d82ff3
Compare
harshil-goel
force-pushed
the
harshil-goel/cache-new
branch
from
45c9b8b to
9d87eb4
Compare
harshil-goel
commented
Jan 2, 2025
harshil-goel
commented
Jan 2, 2025
harshil-goel
commented
Jan 2, 2025
mangalaman93
requested changes
Jan 6, 2025
harshil-goel
force-pushed
the
harshil-goel/cache-new
branch
from
b2b64b3 to
16f36d3
Compare
mangalaman93
previously approved these changes
Jan 8, 2025
mangalaman93
approved these changes
Jan 13, 2025
| @@ -145,6 +145,8 @@ they form a Raft group and provide synchronous replication. | |||
| Flag("percentage", | |||
| "Cache percentages summing up to 100 for various caches (FORMAT: PostingListCache,"+ | |||
| "PstoreBlockCache,PstoreIndexCache)"). | |||
| Flag("keep-updates", | |||
There was a problem hiding this comment.
delete-on-update
On true, we delete the key from cache when an update is made to the same key. Otherwise, we do an in place update in cache.
what difference does this parameter make to Dgraph?
matthewmcneely
added a commit
that referenced
this pull request
Jan 15, 2025
commit 408e064 Author: Ryan Fox-Tyler <[email protected]> Date: Wed Jan 15 06:35:35 2025 -0800 chore: init trunk (#9273) **Description** Initializing Trunk for formatting and linting across the repo **Checklist** - [X] Code compiles correctly and linting passes locally commit ee60263 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed Jan 15 13:23:32 2025 +0530 chore(deps): Update go minor and patch (#9267) commit 02b9d13 Author: Harshil Goel <[email protected]> Date: Mon Jan 13 18:31:26 2025 +0530 fix(core): change name of config flag for cache (#9274) commit ee99a7a Author: Harshil Goel <[email protected]> Date: Mon Jan 13 14:16:40 2025 +0530 perf(core): Fixing ristretto cache to pass jepsen tests (#9237)
matthewmcneely
pushed a commit
that referenced
this pull request
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.