chore(deps): update prometheus dependency #8655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangalaman93
force-pushed
the
joshua/prom
branch
from
e0d1d4e to
490fea5
Compare
mangalaman93
requested review from
akon-dey,
skrdgraph,
darkn3rd,
meghalims,
matthewmcneely and
billprovince
as code owners
mangalaman93
force-pushed
the
joshua/prom
branch
from
490fea5 to
f868a33
Compare
harshil-goel
approved these changes
Feb 9, 2023
harshil-goel
approved these changes
Feb 9, 2023
mangalaman93
approved these changes
Feb 9, 2023
This removes the metric `go_memstats_gc_cpu_fraction`. This metric is not useful and often misleading due to the fact that it's an average over the lifetime of the process. See prometheus/client_golang#842 (comment) These are the new metrics that are added: go_cgo_go_to_c_calls_calls_total go_cpu_classes_gc_mark_assist_cpu_seconds_total go_cpu_classes_gc_mark_dedicated_cpu_seconds_total go_cpu_classes_gc_mark_idle_cpu_seconds_total go_cpu_classes_gc_pause_cpu_seconds_total go_cpu_classes_gc_total_cpu_seconds_total go_cpu_classes_idle_cpu_seconds_total go_cpu_classes_scavenge_assist_cpu_seconds_total go_cpu_classes_scavenge_background_cpu_seconds_total go_cpu_classes_scavenge_total_cpu_seconds_total go_cpu_classes_total_cpu_seconds_total go_cpu_classes_user_cpu_seconds_total go_gc_cycles_automatic_gc_cycles_total go_gc_cycles_forced_gc_cycles_total go_gc_cycles_total_gc_cycles_total go_gc_heap_allocs_by_size_bytes_bucket go_gc_heap_allocs_by_size_bytes_count go_gc_heap_allocs_by_size_bytes_sum go_gc_heap_allocs_bytes_total go_gc_heap_allocs_objects_total go_gc_heap_frees_by_size_bytes_bucket go_gc_heap_frees_by_size_bytes_count go_gc_heap_frees_by_size_bytes_sum go_gc_heap_frees_bytes_total go_gc_heap_frees_objects_total go_gc_heap_goal_bytes go_gc_heap_objects_objects go_gc_heap_tiny_allocs_objects_total go_gc_limiter_last_enabled_gc_cycle go_gc_pauses_seconds_bucket go_gc_pauses_seconds_count go_gc_pauses_seconds_sum go_gc_stack_starting_size_bytes go_memory_classes_heap_free_bytes go_memory_classes_heap_objects_bytes go_memory_classes_heap_released_bytes go_memory_classes_heap_stacks_bytes go_memory_classes_heap_unused_bytes go_memory_classes_metadata_mcache_free_bytes go_memory_classes_metadata_mcache_inuse_bytes go_memory_classes_metadata_mspan_free_bytes go_memory_classes_metadata_mspan_inuse_bytes go_memory_classes_metadata_other_bytes go_memory_classes_os_stacks_bytes go_memory_classes_other_bytes go_memory_classes_profiling_buckets_bytes go_memory_classes_total_bytes go_sched_gomaxprocs_threads go_sched_goroutines_goroutines go_sched_latencies_seconds_bucket go_sched_latencies_seconds_count go_sched_latencies_seconds_sum go_sync_mutex_wait_total_seconds_total
mangalaman93
force-pushed
the
joshua/prom
branch
from
f868a33 to
07d5374
Compare
all-seeing-code
approved these changes
Feb 9, 2023
|
Good point, Anurag. I think we will figure these metrics out as we go. |
skrdgraph
added a commit
that referenced
this pull request
Mar 17, 2023
Similar to #8743 but two changes. - github.com/dgraph-io/graphql-transport-ws did not have any CVE's, see #8624: - Bumping google.golang.org/[email protected] to v1.52.0 caused issues, but this was not a CVE fix. See #8655 We now have parity with main branch (i.e. equal number and same CVE's on main and slash). --------- Co-authored-by: skrdgraph <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use latest version of Prometheus @damonfeldman
The only metric that is removed is
go_memstats_gc_cpu_fraction. The reason is explained in the comment below, this is from the library code itself:These are the new metrics that are added with 1.19
These will be added once we upgrade to Go 1.20
The whole analysis is available at: https://docs.google.com/spreadsheets/d/1rbkvweEtxrK7VLr8xU-gYwRBlCg6h2nTUXXnjkUq7sI/edit?usp=sharing