Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(restore): introduce incremental restore (#7942) #8624

Merged
merged 2 commits into from
Mar 15, 2023
Merged

Conversation

mangalaman93
Copy link
Member

@mangalaman93 mangalaman93 commented Jan 20, 2023

This commit introduces incremental restore. It allows incremental backups to be restored on top of a set of already restored backups. In between two incremental restores, the cluster is in draining mode.

fixes #8533

@CLAassistant
Copy link

CLAassistant commented Jan 20, 2023

CLA assistant check
All committers have signed the CLA.

@mangalaman93 mangalaman93 added the slash-to-main PRs which bring slash branch on par with main. label Jan 20, 2023
@mangalaman93
Copy link
Member Author

More tests to add:

  • drop namespace should work as expected
  • change in graphql schema should also show up after incremental restore

@mangalaman93 mangalaman93 force-pushed the aman/lock branch 2 times, most recently from f0b4621 to 2163656 Compare February 2, 2023 05:17
Base automatically changed from aman/lock to main February 2, 2023 08:55
@mangalaman93 mangalaman93 marked this pull request as draft February 13, 2023 09:19
@mangalaman93 mangalaman93 marked this pull request as ready for review February 14, 2023 20:25
@coveralls
Copy link

Coverage Status

Coverage: 66.949% (+0.05%) from 66.902% when pulling a76d18f on aman/incr into 2908651 on main.

@mangalaman93 mangalaman93 marked this pull request as draft February 15, 2023 18:00
@mangalaman93 mangalaman93 force-pushed the aman/incr branch 3 times, most recently from c7f6c5a to 870b8ab Compare February 24, 2023 13:08
@mangalaman93 mangalaman93 force-pushed the aman/incr branch 3 times, most recently from 3e485b5 to 825dc2d Compare March 6, 2023 20:27
@mangalaman93 mangalaman93 marked this pull request as ready for review March 6, 2023 21:26
@joshua-goldstein joshua-goldstein self-requested a review March 7, 2023 19:21
@mangalaman93 mangalaman93 force-pushed the aman/incr branch 3 times, most recently from ac1a070 to ec61a62 Compare March 7, 2023 19:56
@MichelDiz MichelDiz added the dgraph Issue or PR created by an internal Dgraph contributor. label Mar 7, 2023
This commit introduces incremental restore. It allows incremental
backups to be restored on top of a set of already restored backups.
In between two incremental restores, the cluster is in draining mode.
@mangalaman93 mangalaman93 merged commit 8b3712e into main Mar 15, 2023
@mangalaman93 mangalaman93 deleted the aman/incr branch March 15, 2023 15:58
skrdgraph added a commit that referenced this pull request Mar 17, 2023
Similar to #8743 but two
changes.
- github.com/dgraph-io/graphql-transport-ws did not have any CVE's, see
#8624:
- Bumping google.golang.org/[email protected] to v1.52.0 caused issues, but
this was not a CVE fix. See
#8655

We now have parity with main branch (i.e. equal number and same CVE's on
main and slash).

---------

Co-authored-by: skrdgraph <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dgraph Issue or PR created by an internal Dgraph contributor. slash-to-main PRs which bring slash branch on par with main.
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT]: incremental restore
6 participants