Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixing audit logs for websocket connections (#8048) (#8053) #8627

Merged
merged 5 commits into from
Jan 24, 2023
Merged

fix: fixing audit logs for websocket connections (#8048) (#8053) #8627

merged 5 commits into from
Jan 24, 2023

Conversation

all-seeing-code
Copy link
Contributor

@all-seeing-code all-seeing-code commented Jan 24, 2023 •
edited
Loading

Fixing audit logs for websocket connections

(cherry picked from commit 3f8cff9)

@aman-bansal @all-seeing-code
fix: fixing audit logs for websocket connections (#8048) (#8053)
0e39a1d 
* fix: fixing audit logs for websocket connections

(cherry picked from commit 3f8cff9)
@CLAassistant
Copy link

CLAassistant commented Jan 24, 2023 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ anurags92
❌ aman-bansal
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added area/commercial area/graphql Issues related to GraphQL support on Dgraph. labels Jan 24, 2023
@all-seeing-code all-seeing-code marked this pull request as ready for review January 24, 2023 10:02
@all-seeing-code
Address review comments
2507e8a 
(cherry picked from commit 191c568)
@skrdgraph
Copy link
Contributor

now it seems to have picked up the arm64 CI job. did you have to rebase it?

@all-seeing-code
tiny fix
48fda48 
(cherry picked from commit f171d99)
@all-seeing-code
Address PR comments
a43caa3 
(cherry picked from commit 062d91a)
@all-seeing-code
Address comments
e9404bb 
(cherry picked from commit 9448c4a)
@all-seeing-code
Copy link
Contributor Author

now it seems to have picked up the arm64 CI job. did you have to rebase it?

I didn't rebase it but created a new branch over the latest main. Felt it would be cleaner and avoid any other issues. I'll track if this passes and then ask for reviews again.

@all-seeing-code all-seeing-code added the slash-to-main PRs which bring slash branch on par with main. label Jan 24, 2023
@coveralls
Copy link

coveralls commented Jan 24, 2023 •
edited
Loading

Coverage Status

Coverage: 66.686% (-0.3%) from 67.028% when pulling e9404bb on anurag/cp-audit-log-websocket into 693677e on main.

skrdgraph
skrdgraph approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@skrdgraph skrdgraph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@all-seeing-code all-seeing-code merged commit 2771e33 into main Jan 24, 2023
@all-seeing-code all-seeing-code deleted the anurag/cp-audit-log-websocket branch January 24, 2023 11:47
all-seeing-code added a commit that referenced this pull request Feb 8, 2023
@all-seeing-code @aman-bansal
fix: fixing audit logs for websocket connections (#8048) (#8053) (#8627)
c697086 
Fixing audit logs for websocket connections

(cherry picked from commit 3f8cff9)

Co-authored-by: aman bansal <[email protected]>
all-seeing-code added a commit that referenced this pull request Feb 8, 2023
@all-seeing-code @aman-bansal
fix: fixing audit logs for websocket connections (#8048) (#8053) (#8627)
af429b6 
Fixing audit logs for websocket connections

(cherry picked from commit 3f8cff9)

Co-authored-by: aman bansal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skrdgraph skrdgraph skrdgraph approved these changes

@akon-dey akon-dey Awaiting requested review from akon-dey

@MichelDiz MichelDiz Awaiting requested review from MichelDiz

@matthewmcneely matthewmcneely Awaiting requested review from matthewmcneely

@darkn3rd darkn3rd Awaiting requested review from darkn3rd

@meghalims meghalims Awaiting requested review from meghalims

@billprovince billprovince Awaiting requested review from billprovince

@mangalaman93 mangalaman93 Awaiting requested review from mangalaman93

@harshil-goel harshil-goel Awaiting requested review from harshil-goel

Assignees
No one assigned
Labels
area/graphql Issues related to GraphQL support on Dgraph. slash-to-main PRs which bring slash branch on par with main.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@all-seeing-code @CLAassistant @skrdgraph @coveralls @mangalaman93 @aman-bansal