fix: fixing audit logs for websocket connections #8048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/enterprise
NamanJain8
approved these changes
Sep 22, 2021
aman-bansal
force-pushed
the
aman/fix_websocket_audit
branch
from
12b4d6a to
e16170d
Compare
aman-bansal
added a commit
that referenced
this pull request
Sep 24, 2021
* fix: fixing audit logs for websocket connections
aman-bansal
added a commit
that referenced
this pull request
Sep 24, 2021
all-seeing-code
pushed a commit
that referenced
this pull request
Jan 4, 2023
all-seeing-code
pushed a commit
that referenced
this pull request
Jan 19, 2023
all-seeing-code
pushed a commit
that referenced
this pull request
Jan 20, 2023
all-seeing-code
added a commit
that referenced
this pull request
Jan 23, 2023
Fix audit logs for requests over websocket. (cherry picked from commit 3f8cff9) Co-authored-by: aman bansal <[email protected]>
all-seeing-code
added a commit
that referenced
this pull request
Jan 24, 2023
all-seeing-code
added a commit
that referenced
this pull request
Jan 24, 2023
all-seeing-code
pushed a commit
that referenced
this pull request
Jan 24, 2023
all-seeing-code
added a commit
that referenced
this pull request
Jan 24, 2023
Fixing audit logs for websocket connections (cherry picked from commit 3f8cff9) Co-authored-by: aman bansal <[email protected]>
all-seeing-code
added a commit
that referenced
this pull request
Feb 8, 2023
Fixing audit logs for websocket connections (cherry picked from commit 3f8cff9) Co-authored-by: aman bansal <[email protected]>
all-seeing-code
added a commit
that referenced
this pull request
Feb 8, 2023
Fix audit logs for requests over websocket. (cherry picked from commit 3f8cff9) Co-authored-by: aman bansal <[email protected]>
all-seeing-code
added a commit
that referenced
this pull request
Feb 8, 2023
all-seeing-code
added a commit
that referenced
this pull request
Feb 8, 2023
Fixing audit logs for websocket connections (cherry picked from commit 3f8cff9) Co-authored-by: aman bansal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Audits were made to operate as a middleware for all the requests over the 8080 port of Dgraph alpha. This works great for grpc and http requests but not for graphQL subscriptions over websockets. websocket connections works in different way. They start as normal Http connection and then gets upgraded to the websocket connection. Till the upgrade is over, there is no transfer of metadata and headers across the network. This makes auditing impossible at the middleware layer for websocket connections.
This PR separates out the audit for websockets connection to the http.go#subscriber which will handle the auditing in the right manner.
This change is