Test(acl): Add a test case to verify identical name for group and user work with acl #8454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ify the fix pushed in (#7978)
all-seeing-code
requested review from
akon-dey,
skrdgraph and
darkn3rd
as code owners
all-seeing-code
changed the title
matthewmcneely
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a test case for the fix implemented in #7978.
For the test case we need to create a user and the group with the same name. Dgraph stores ACL information in the predicate
dgraph.xidwhich is shared between group and user information. The test prevents a regression in the case where the names of the group and user are identical.Test
TestQueriesWithUserAndGroupOfSameName