fix(acl): filter out the results based on type #7978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NamanJain8
added a commit
that referenced
this pull request
Aug 12, 2021
We store the groupId and userId in a predicate named dgraph.xid.There was a subtle bug where if a we create the group with same name as that of a user, then the user is not able to log in. This happens because we were not applying a filter by type. This PR fixes that. (cherry picked from commit 3553855)
NamanJain8
added a commit
that referenced
this pull request
Aug 12, 2021
We store the groupId and userId in a predicate named dgraph.xid.There was a subtle bug where if a we create the group with same name as that of a user, then the user is not able to log in. This happens because we were not applying a filter by type. This PR fixes that. (cherry picked from commit 3553855)
NamanJain8
added a commit
that referenced
this pull request
Aug 12, 2021
We store the groupId and userId in a predicate named dgraph.xid.There was a subtle bug where if a we create the group with same name as that of a user, then the user is not able to log in. This happens because we were not applying a filter by type. This PR fixes that. (cherry picked from commit 3553855)
NamanJain8
added a commit
that referenced
this pull request
Aug 12, 2021
We store the groupId and userId in a predicate named dgraph.xid.There was a subtle bug where if a we create the group with same name as that of a user, then the user is not able to log in. This happens because we were not applying a filter by type. This PR fixes that. (cherry picked from commit 3553855)
ahsanbarkati
pushed a commit
that referenced
this pull request
Sep 15, 2021
We store the groupId and userId in a predicate named dgraph.xid.There was a subtle bug where if a we create the group with same name as that of a user, then the user is not able to log in. This happens because we were not applying a filter by type. This PR fixes that. (cherry picked from commit 3553855) (cherry picked from commit ff9ef37)
all-seeing-code
added a commit
that referenced
this pull request
Nov 24, 2022
…ify the fix pushed in (#7978)
all-seeing-code
added a commit
that referenced
this pull request
Nov 29, 2022
…r work with acl (#8454) ## Description Adds a test case for the fix implemented in #7978. For the test case we need to create a user and the group with the same name. Dgraph stores ACL information in the predicate `dgraph.xid` which is shared between group and user information. The test prevents a regression in the case where the names of the group and user are identical. ## Test `TestQueriesWithUserAndGroupOfSameName`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We store the groupId and userId in a predicate named
dgraph.xid.There was a subtle bug where if a we create the group with same name as that of a user, then the user is not able to log in. This happens because we were not applying a filter by type.This PR fixes that.
This change is