Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add ci workflow for arm64 #8405

Merged
merged 10 commits into from
Nov 4, 2022
Merged

Conversation

joshua-goldstein
Copy link
Contributor

@joshua-goldstein joshua-goldstein commented Nov 2, 2022

Problem

We would like to support arm64. Toward that end we want to add a ci job that will run tests on an arm instance. This is a WIP because some tests are failing (see remarks below)

Solution

go get github.com/dgraph-io/[email protected]
go get github.com/dgraph-io/badger/[email protected]
go mod tidy 
  • Remove GOOS/GOARCH constraints in Makefile and CI workflow.

Current test failures

These are all of the places we currently see failures. Unfortunately the skip flag in t.go is unable to skip these particular tests in graphql. All other tests are passing.

graphql/e2e/normal
graphql/e2e/directives
graphql/e2e/custom_logic
systest/export

Remarks

I was experimenting with a fresh arm64 instance and running tests on there (same or very similar environment to CI environment). These look like nontrivial failures that need to be investigated.

I have a script that does all the setup (Go, Docker, etc.) in a similar way to the CI environment but for arm (see here).

Todo

Set up Github actions to run these jobs on an arm instance automatically, once we have a baseline.

@github-actions github-actions bot added the area/integrations Related to integrations with other projects. label Nov 2, 2022
@joshua-goldstein
Copy link
Contributor Author

joshua-goldstein commented Nov 2, 2022

Thanks @adityasadalage for also taking a look at this, I was debating whether to reopen your PR and make these changes there but it seemed like a lot to push. If you see anything here that can be modified please feel free to edit as necessary.

@CLAassistant
Copy link

CLAassistant commented Nov 2, 2022

CLA assistant check
All committers have signed the CLA.

@@ -16,7 +16,7 @@ on:
jobs:
dgraph-load-tests:
if: github.event.pull_request.draft == false
runs-on: self-hosted
runs-on: [self-hosted, X64]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small check is needed here - is this an and or or?

Copy link
Contributor Author

@joshua-goldstein joshua-goldstein Nov 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AND, confirmed here..

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 ^ thanks!

@joshua-goldstein joshua-goldstein marked this pull request as ready for review November 4, 2022 23:27
@joshua-goldstein joshua-goldstein changed the title chore: add ci workflow for arm64 instance chore(ci): add ci workflow for arm64 Nov 4, 2022
@skrdgraph skrdgraph merged commit a146121 into main Nov 4, 2022
@skrdgraph skrdgraph deleted the joshua/add-arm64-ci-job branch November 4, 2022 23:49
@coveralls
Copy link

Coverage Status

Coverage remained the same at 37.18% when pulling cee8b32 on joshua/add-arm64-ci-job into 855974e on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/integrations Related to integrations with other projects.
Development

Successfully merging this pull request may close these issues.

5 participants