-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): add ci workflow for arm64 #8405
Conversation
Thanks @adityasadalage for also taking a look at this, I was debating whether to reopen your PR and make these changes there but it seemed like a lot to push. If you see anything here that can be modified please feel free to edit as necessary. |
@@ -16,7 +16,7 @@ on: | |||
jobs: | |||
dgraph-load-tests: | |||
if: github.event.pull_request.draft == false | |||
runs-on: self-hosted | |||
runs-on: [self-hosted, X64] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small check is needed here - is this an and
or or
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AND, confirmed here..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 ^ thanks!
6fd8844
to
ab22464
Compare
Problem
We would like to support arm64. Toward that end we want to add a ci job that will run tests on an arm instance. This is a WIP because some tests are failing (see remarks below)
Solution
Current test failures
These are all of the places we currently see failures. Unfortunately the skip flag in t.go is unable to skip these particular tests in graphql. All other tests are passing.
graphql/e2e/normal
graphql/e2e/directives
graphql/e2e/custom_logic
systest/export
Remarks
I was experimenting with a fresh arm64 instance and running tests on there (same or very similar environment to CI environment). These look like nontrivial failures that need to be investigated.
I have a script that does all the setup (Go, Docker, etc.) in a similar way to the CI environment but for arm (see here).
Todo
Set up Github actions to run these jobs on an arm instance automatically, once we have a baseline.