fix(deps): update dependencies on badger + ristretto #8365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-goldstein
requested review from
akon-dey,
gcxml,
skrdgraph,
darkn3rd and
meghalims
as code owners
|
@joshua-goldstein lets wait for 24hrs before getting this in ... this looks okay to merge. |
|
Pushing this out to next release (marking draft temporarily) |
joshua-goldstein
force-pushed
the
joshua/update-badger-ristretto
branch
from
d6003db to
36ad2d3
Compare
|
@skrdgraph I have rebased this PR and updated the dependency on Badger to v3.2103.4 (latest). So this is ready to merge. |
matthewmcneely
approved these changes
Nov 4, 2022
skrdgraph
pushed a commit
that referenced
this pull request
Nov 4, 2022
## Problem We would like to support arm64. Toward that end we want to add a ci job that will run tests on an arm instance. This is a WIP because some tests are failing (see remarks below) ## Solution - Get the latest Ristretto and Badger versions that fixed certain arm64 issues. This is also in a PR #8365 that has not been merged yet. ``` go get github.com/dgraph-io/[email protected] go get github.com/dgraph-io/badger/[email protected] go mod tidy ``` - Remove GOOS/GOARCH constraints in Makefile and CI workflow. ## Current test failures These are all of the places we currently see failures. Unfortunately the skip flag in t.go is unable to skip these particular tests in graphql. All other tests are passing. [graphql/e2e/normal](https://gist.github.com/joshua-goldstein/fcd4579ee7366a13b9e28eacad20a2b7) [graphql/e2e/directives](https://gist.github.com/joshua-goldstein/a339d5a285c621aa3e4045f407a87804) [graphql/e2e/custom_logic](https://gist.github.com/joshua-goldstein/48d91ac2969ddc29afd705d07186fb8b) [systest/export](https://gist.github.com/joshua-goldstein/39eaa83e277eb53101c7edc46aca0b83) ## Remarks I was experimenting with a fresh arm64 instance and running tests on there (same or very similar environment to CI environment). These look like nontrivial failures that need to be investigated. I have a script that does all the setup (Go, Docker, etc.) in a similar way to the CI environment but for arm (see [here](https://gist.github.com/joshua-goldstein/2c0a90192ed46a4145e3d2495e4e1c48)). ## Todo Set up Github actions to run these jobs on an arm instance automatically, once we have a baseline. Co-authored-by: adityasadalage <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Dgraph currently uses Ristretto v0.1.0 and Badger v3.2103.1. We encounter certain issues on arm64 machines that were patched in Ristretto v0.1.1 and Badger v3.2103.3. Badger v3.2103.4 also fixes a potential manifest corruption issue.
Solution
We bump up the dependencies.
Remark
Changelog of Badger v3.2103.1 to v3.2103.2
Changelog of Badger v3.2103.2 to v3.2103.3
Changelog of Badger v3.2103.2 to v3.2103.4
Changelog of Ristretto v0.1.0 to v0.1.1