cherry-pick v20.11/slash: Fix(query): Fix pagination with match functions #7678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix queries involving `regexp`, `allofterms`, `alloftext` and `match` function with pagination. These functions relies on indexes and needs to fetch postings/uids for each relevant index key to generate the final result. Remove early pagination for these cases. (cherry picked from commit e00ed67)
danielmai
approved these changes
Apr 1, 2021
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @pawanrawal)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix queries involving
regexp,allofterms,alloftextandmatchfunction with pagination. These functions relies on indexes and
needs to fetch postings/uids for each relevant index key to generate
the final result. Remove early pagination for these cases.
(cherry picked from commit e00ed67)
This change is