fix(query): Fix pagination with match functions #7668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, please cherry-pick it to release/v20.11 |
ahsanbarkati
added a commit
that referenced
this pull request
Mar 31, 2021
Fix queries involving `regexp`, `allofterms`, `alloftext` and `match` function with pagination. These functions relies on indexes and needs to fetch postings/uids for each relevant index key to generate the final result. Remove early pagination for these cases. (cherry picked from commit e00ed67)
ahsanbarkati
added a commit
that referenced
this pull request
Mar 31, 2021
Fix queries involving `regexp`, `allofterms`, `alloftext` and `match` function with pagination. These functions relies on indexes and needs to fetch postings/uids for each relevant index key to generate the final result. Remove early pagination for these cases. (cherry picked from commit e00ed67)
ahsanbarkati
added a commit
that referenced
this pull request
Apr 1, 2021
Fix queries involving `regexp`, `allofterms`, `alloftext` and `match` function with pagination. These functions relies on indexes and needs to fetch postings/uids for each relevant index key to generate the final result. Remove early pagination for these cases. (cherry picked from commit e00ed67)
ahsanbarkati
added a commit
that referenced
this pull request
Apr 1, 2021
Fix queries involving `regexp`, `allofterms`, `alloftext` and `match` function with pagination. These functions relies on indexes and needs to fetch postings/uids for each relevant index key to generate the final result. Remove early pagination for these cases. (cherry picked from commit e00ed67)
aman-bansal
pushed a commit
that referenced
this pull request
Apr 8, 2021
Fix queries involving `regexp`, `allofterms`, `alloftext` and `match` function with pagination. These functions relies on indexes and needs to fetch postings/uids for each relevant index key to generate the final result. Remove early pagination for these cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to narrowing down the query to only fetch N results from the
postings, some of the queries got broken. Some queries like
alloftermsrequires fetching all the uids/postings from the posting listcorresponding to each term relevant to the queries. And then do an
intersection of the results corresponding to each token.
This change is