clusterID flag added for alpha sentry reports (gql-services) #7580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thsubaku9-pro
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
aman-bansal
suggested changes
Mar 16, 2021
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @jarifibrahim, @manishrjain, @thsubaku9-dgraph, and @vvbalaji-dgraph)
dgraph/cmd/zero/raft.go, line 534 at r1 (raw file):
id := uuid.New().String() if zero_cid := Zero.Conf.GetString("cid"); len(zero_cid) > 0 {
we don't use snake case of variable naming in go. use camelcase
|
QQ, why do we need custom cluster id? any specific use case? |
camelCase it is
This will be used to tag specific clusters in sentry. The CID is used only in sentry. |
aman-bansal
pushed a commit
that referenced
this pull request
Apr 7, 2021
* clusterID flag added for alpha sentry reports (gql-services) * Update raft.go camelCase it is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cluster ID flag for providing the same via flag -- reason for dgraph/cmd/zero/run.go changes
provided cluster ID should be set to alphas from Zero.Conf -- reason for dgraph/cmd/zero/raft.go changes
(images aren't made if dir linux already exists, adding -p takes care of it -- reason for Makefile changes)
This change is