Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENHANCEMENT]: clusterID flag added for alpha sentry reports (gql-services) #8484

Closed
rderbier opened this issue Dec 5, 2022 · 4 comments
Closed

[ENHANCEMENT]: clusterID flag added for alpha sentry reports (gql-services) #8484

rderbier opened this issue Dec 5, 2022 · 4 comments
Labels
dgraph Issue or PR created by an internal Dgraph contributor. kind/enhancement Something could be better. v21.12 supposedly corrected in v21.12

Comments

@rderbier
Copy link
Member

rderbier commented Dec 5, 2022 •
edited
Loading

What you wanted to do.

PR from v21.12 : #7580
@rderbier rderbier added kind/enhancement Something could be better. dgraph Issue or PR created by an internal Dgraph contributor. v21.12 supposedly corrected in v21.12 labels Dec 5, 2022
@rderbier
Copy link
Member Author

rderbier commented Dec 5, 2022

Need to clarify the use case, the benefit and if this one is solving an issue or enhancing product quality.

@rderbier rderbier moved this to 👀 In review in Feature Requests - PM RoadMap Dec 5, 2022
@mangalaman93
Copy link
Member

@MichelDiz could you check if this is useful? I don't think we are using sentry (we should though) and maybe this is useful for other reports that we get from various clusters?

@mangalaman93
Copy link
Member

This is already present in main #7580 eeab3fb

@MichelDiz
Copy link
Contributor

@mangalaman93 in general it is not useful for telemetry. Can be for Sentry. About that I can't tell much.

We should verify and decide to remove. Cuz this can cause confusion in the telemetry data. As users can play with it. I've seen two cluster with funny names...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dgraph Issue or PR created by an internal Dgraph contributor. kind/enhancement Something could be better. v21.12 supposedly corrected in v21.12
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mangalaman93 @MichelDiz @rderbier