Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(GraphQL): Fix failing auth tests #6923

Merged
merged 1 commit into from
Nov 19, 2020
Merged

Fix(GraphQL): Fix failing auth tests #6923

merged 1 commit into from
Nov 19, 2020

Conversation

vmrajas
Copy link
Contributor

@vmrajas vmrajas commented Nov 19, 2020 •
edited by manishrjain
Loading

Motivation:
Recently, the PR, #6907 was pushed to master which resulted in failure of auth tests. This PR fixes those failing tests.
Testing:
Tested Manually.
rajas@rajas-ThinkPad-T490:~/Github/dgraph/graphql/e2e/auth|master⚡ ⇒ go test
[Decoder]: Using assembly version of decoder
testutil: "" localhost:9080 localhost:5080
PASS
PASS
ok github.com/dgraph-io/dgraph/graphql/e2e/auth 43.578s

This change is Reviewable

@vmrajas vmrajas requested a review from aman-bansal November 19, 2020 14:17
@github-actions github-actions bot added the area/graphql Issues related to GraphQL support on Dgraph. label Nov 19, 2020
@aman-bansal aman-bansal merged commit 74fb2c7 into master Nov 19, 2020
@vmrajas vmrajas deleted the rajas/fix_tests branch November 20, 2020 10:31
vmrajas added a commit that referenced this pull request Nov 20, 2020
@vmrajas
Fix failing auth tests (#6923)
51487df 
(cherry picked from commit 74fb2c7)
vmrajas added a commit that referenced this pull request Nov 20, 2020
@vmrajas
Fix(GraphQL): Add support for using auth with secret directive (#6907) (
ba63d03 
#6920)

* Fix(GraphQL): Add support for using auth with secret directive (#6907)

* Add password field in auth directive

* Add query resolving tests

* Add e2e tests

* Address feedback

(cherry picked from commit 3311923)

* Fix failing auth tests (#6923)

(cherry picked from commit 74fb2c7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aman-bansal aman-bansal aman-bansal approved these changes

@MichaelJCompton MichaelJCompton Awaiting requested review from MichaelJCompton

@pawanrawal pawanrawal Awaiting requested review from pawanrawal

Assignees
No one assigned
Labels
area/graphql Issues related to GraphQL support on Dgraph.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmrajas @aman-bansal