Fix(GraphQL): Add support for using auth with secret directive (#6907) #6920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add password field in auth directive * Add query resolving tests * Add e2e tests * Address feedback (cherry picked from commit 3311923)
github-actions
bot
added
the
area/graphql
…as/secret-with-auth-directive
(cherry picked from commit 74fb2c7)
pawanrawal
approved these changes
Nov 20, 2020
There was a problem hiding this comment.
Reviewed 61 of 61 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @MichaelJCompton)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add password field in auth directive
Add query resolving tests
Add e2e tests
Address feedback
(cherry picked from commit 3311923)
This change is