fix(Ludicrous): Upserts on list type in Dgraph #6796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix DGRAPH-2446: Dgraph missing upserts in ludicrous mode * Add tests * Address review comments * Add a space
* Add sleep before running the tests * Fix the assert in tests * Wait for eventual consistency
rahulgurnani
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
danielmai
approved these changes
Oct 23, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jarifibrahim, @manishrjain, and @vvbalaji-dgraph)
danielmai
suggested changes
Oct 23, 2020
There was a problem hiding this comment.
The tests don't compile in this branch:
# github.com/dgraph-io/dgraph/systest/ludicrous [github.com/dgraph-io/dgraph/systest/ludicrous.test]
./upsert_test.go:54:39: cannot use &"github.com/dgraph-io/dgo/v200/protos/api".Operation literal (type *"github.com/dgraph-io/dgo/v200/protos/api".Operation) as type *"github.com/dgraph-io/dgo/v2/protos/api".Operation in argument to dg.Alter
./upsert_test.go:72:21: cannot use mu (type *"github.com/dgraph-io/dgo/v200/protos/api".Mutation) as type *"github.com/dgraph-io/dgo/v2/protos/api".Mutation in argument to txn.Mutate
./upsert_test.go:100:27: cannot use req (type *"github.com/dgraph-io/dgo/v200/protos/api".Request) as type *"github.com/dgraph-io/dgo/v2/protos/api".Request in argument to dg.NewTxn().Do
./upsert_test.go:148:27: cannot use req (type *"github.com/dgraph-io/dgo/v200/protos/api".Request) as type *"github.com/dgraph-io/dgo/v2/protos/api".Request in argument to dg.NewTxn().Do
FAIL github.com/dgraph-io/dgraph/systest/ludicrous [build failed]
Reviewable status:
danielmai
approved these changes
Oct 23, 2020
There was a problem hiding this comment.
Oops. I meant to send the above comment for #6797. The tests are OK here in rahulgurnani/releasev2007cp. Merging.
Reviewable status:
danielmai
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Post mortem of issue: https://discuss.dgraph.io/t/dgraph-missing-mutations-in-ludicrous-mode-post-mortem/11019
This change is
Docs Preview: