fix(Ludicrous): Upserts on list type in Dgraph #6754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulgurnani
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
jarifibrahim
approved these changes
Oct 19, 2020
There was a problem hiding this comment.
Some minor comments. Good work @rahulgurnani . This was a hairy bug!
systest/ludicrous/upsert_test.go
Outdated
| } | ||
|
|
||
| func TestSequentialUpdate(t *testing.T) { | ||
| t.Log("TestSequentialUpdate") |
systest/ludicrous/upsert_test.go
Outdated
| require.NoError(t, err) | ||
| schema := ` | ||
| name: string @index(exact) . | ||
| email: string @index(exact) . |
There was a problem hiding this comment.
You can remove the email. It seems like we're not using it anywhere.
systest/ludicrous/upsert_test.go
Outdated
| @@ -0,0 +1,152 @@ | |||
| package worker | |||
There was a problem hiding this comment.
This should be main. Also, the license is missing.
systest/ludicrous/upsert_test.go
Outdated
| wg.Add(count) | ||
| mutation := func(i int) { | ||
| defer wg.Done() | ||
| query := fmt.Sprintf(`query { |
There was a problem hiding this comment.
query := .... would also work. You don't need the fmt.Sprintf
rahulgurnani
force-pushed
the
rahulgurnani/ludicrous_fixes
branch
from
682b57b to
b2104bf
Compare
rahulgurnani
force-pushed
the
rahulgurnani/ludicrous_fixes
branch
from
bbc0784 to
f74c9d7
Compare
rahulgurnani
added a commit
that referenced
this pull request
Oct 23, 2020
* Fix DGRAPH-2446: Dgraph missing upserts in ludicrous mode * Add tests * Address review comments * Add a space
rahulgurnani
added a commit
that referenced
this pull request
Oct 23, 2020
* Fix DGRAPH-2446: Dgraph missing upserts in ludicrous mode * Add tests * Address review comments * Add a space
rahulgurnani
added a commit
that referenced
this pull request
Oct 23, 2020
* Fix DGRAPH-2446: Dgraph missing upserts in ludicrous mode * Add tests * Address review comments * Add a space
danielmai
pushed a commit
that referenced
this pull request
Oct 23, 2020
Cherry-pick of the following into release/v20.07: * fix(Ludicrous): Upserts on list type in Dgraph (#6754) * fix(test): Add sleep before running ludicrous mode tests (#6766) Fixes DGRAPH-2446. Post mortem of issue: https://discuss.dgraph.io/t/dgraph-missing-mutations-in-ludicrous-mode-post-mortem/11019
rahulgurnani
added a commit
that referenced
this pull request
Nov 2, 2020
* Fix DGRAPH-2446: Dgraph missing upserts in ludicrous mode * Add tests * Address review comments * Add a space
rahulgurnani
added a commit
that referenced
this pull request
Nov 3, 2020
* fix(Ludicrous): Upserts on list type in Dgraph (#6754) * Fix DGRAPH-2446: Dgraph missing upserts in ludicrous mode * Add tests * Address review comments * Add a space * fix(test): Add sleep before running ludicrous mode tests (#6766) * Add sleep before running the tests * Fix the assert in tests * Wait for eventual consistency * fix(test): Use dgo/v2 in test for release/v20.03. dgo/v200 is used in release/v20.07 and later. * Add sleep post mutation * Experiment with more sleep Co-authored-by: Daniel Mai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DGRAPH-2446
We were not updating startTs for upsert mutations properly in ludicrous mode.
This change is