Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphql: Recover from panic within goroutines used for resolving custom fields. #5329

Merged
merged 5 commits into from
Apr 30, 2020
+18 −4
Merged

graphql: Recover from panic within goroutines used for resolving custom fields. #5329

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
97a5da9
Recover from panic within goroutines used for resolving custom fields.
pawanrawal Apr 29, 2020
662e4e2
Remove return which wasn't required.
pawanrawal Apr 29, 2020
5ddbbe8
Address Michael's comment.
pawanrawal Apr 30, 2020
e80e4f9
Merge master
pawanrawal Apr 30, 2020
32bb2d1
Merge branch 'master' into pawanrawal/graphql-409
pawanrawal Apr 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove return which wasn't required.
@pawanrawal
pawanrawal committed Apr 29, 2020
commit 662e4e290c02e7b7f35c502c99b343da717f8280
1 change: 0 additions & 1 deletion graphql/resolve/resolver.go
View file
Original file line number Diff line number Diff line change
@@ -807,7 +807,6 @@ func resolveCustomField(f schema.Field, vals []interface{}, mu *sync.RWMutex, er
defer api.PanicHandler(
func(err error) {
errChan <- internalServerError(err, f)
return
})

requestInput := input