graphql: Recover from panic within goroutines used for resolving custom fields. #5329
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recover from any panics encountered within go-routines used for resolving custom fields and return the error back to the client. @MichaelJCompton couldn't find an easy way to add a test for this. I did test this by adding a panic to
makeRequest
and then running an e2e to verify all errors are returned properly. Resolves GRAPHQL-409.This change is