Conversation
Signed-off-by: Justin Florentine <justin+github@florentine.us>
|
There was a problem hiding this comment.
I do not think this is the right way, since adding Blob tx here means that they are considered valid even before Cancun, that is against the protocol specs, since we can accept as valid blocks containing them when still on Shanghai.
We need to understand better the scope of the Hive test and in case change it.
I remember that this was discussed during a ACDE call, and we agreed that tests should not expect blob tx to be present in the pool for the fork block.
ok, that makes sense. Will close this PR, and need more time to open a more extensive one that allows the set of allowedTransaction types to change as the protocol schedule passes. |
covers first block after the fork case, merge after #5961