Apply fcu even on invalid payload#5961
Merged
jflo merged 6 commits intohyperledger:mainfrom Sep 28, 2023
Merged
Conversation
|
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
jflo
force-pushed
the
applyFcuEvenOnInvalidPayload
branch
from
8dd655a to
c1107e4
Compare
Contributor
|
Could you add an example of the invalid payload? |
jflo
added a commit
to jflo/besu
that referenced
this pull request
Nov 10, 2023
* payload validation moved earlier, fcu v2 checks for cancun timestamps * allow fcu when payload invalid --------- Signed-off-by: Justin Florentine <justin+github@florentine.us>
NickSneo
pushed a commit
to NickSneo/besu
that referenced
this pull request
Nov 12, 2023
* payload validation moved earlier, fcu v2 checks for cancun timestamps * allow fcu when payload invalid --------- Signed-off-by: Justin Florentine <justin+github@florentine.us>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes more Hive tests when a payload that is invalid is passed along with an FCU