Skip to content

[MINOR] Block number param additional test #5918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
macfarla merged 2 commits into from
Sep 21, 2023
Merged

[MINOR] Block number param additional test #5918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
537c5db
add test for hex vs decimal block parameter
macfarla Sep 21, 2023
be46b41
typo
macfarla Sep 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...a/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/EthGetBlockByNumberTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,9 @@ public void setUp() {
blockchain.appendBlock(block, receipts);
}

BlockHeader lastestHeader = blockchain.getChainHeadBlock().getHeader();
BlockHeader latestHeader = blockchain.getChainHeadBlock().getHeader();
when(worldStateArchive.isWorldStateAvailable(
lastestHeader.getStateRoot(), lastestHeader.getHash()))
latestHeader.getStateRoot(), latestHeader.getHash()))
.thenReturn(Boolean.TRUE);

blockchainQueries = spy(new BlockchainQueries(blockchain, worldStateArchive));
Expand Down
28 changes: 28 additions & 0 deletions ...ava/org/hyperledger/besu/ethereum/api/jsonrpc/internal/parameters/BlockParameterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,34 @@ public void longShouldReturnLongNumberValue() {
assertThat(blockParameter.isSafe()).isFalse();
}

@Test
public void numberStringShouldReturnLongNumberValue() {
final BlockParameter blockParameter = new BlockParameter("55");
assertThat(blockParameter.getNumber()).isPresent();
assertThat(blockParameter.getNumber().get()).isEqualTo(55L);

assertThat(blockParameter.isNumeric()).isTrue();
assertThat(blockParameter.isEarliest()).isFalse();
assertThat(blockParameter.isFinalized()).isFalse();
assertThat(blockParameter.isLatest()).isFalse();
assertThat(blockParameter.isPending()).isFalse();
assertThat(blockParameter.isSafe()).isFalse();
}

@Test
public void hexShouldReturnLongNumberValue() {
final BlockParameter blockParameter = new BlockParameter("0x55");
assertThat(blockParameter.getNumber()).isPresent();
assertThat(blockParameter.getNumber().get()).isEqualTo(85L);

assertThat(blockParameter.isNumeric()).isTrue();
assertThat(blockParameter.isEarliest()).isFalse();
assertThat(blockParameter.isFinalized()).isFalse();
assertThat(blockParameter.isLatest()).isFalse();
assertThat(blockParameter.isPending()).isFalse();
assertThat(blockParameter.isSafe()).isFalse();
}

@Test
public void upperCaseStringShouldBeHandled() {
final BlockParameter blockParameter = new BlockParameter("LATEST");
Expand Down