Skip to content

[MINOR] Block number param additional test#5918

Merged
macfarla merged 2 commits intohyperledger:mainfrom
macfarla:block-number-param-additional-test
Sep 21, 2023
Merged

[MINOR] Block number param additional test#5918
macfarla merged 2 commits intohyperledger:mainfrom
macfarla:block-number-param-additional-test

Conversation

@macfarla
Copy link
Contributor

Just an additional test to prove that hex and binary are both supported at this level

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@github-actions
Copy link

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

@macfarla macfarla enabled auto-merge (squash) September 21, 2023 06:35
@macfarla macfarla merged commit 277424d into hyperledger:main Sep 21, 2023
@macfarla macfarla deleted the block-number-param-additional-test branch September 24, 2023 23:22
jflo pushed a commit to jflo/besu that referenced this pull request Nov 10, 2023
* add test for hex vs decimal block parameter

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

* typo

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
NickSneo pushed a commit to NickSneo/besu that referenced this pull request Nov 12, 2023
* add test for hex vs decimal block parameter

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

* typo

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants