Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy layered worldstate fix for eth_call #5179

Merged
merged 4 commits into from
Mar 7, 2023

Conversation

garyschulte
Copy link
Contributor

@garyschulte garyschulte commented Mar 7, 2023

PR description

This is mitigation fix for eth_call concurrency failures, similar to #5076.

This mitigation will be obseleted by #5123.

Fixed Issue(s)

#5175

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

Acceptance Tests (Non Mainnet)

  • I have considered running ./gradlew acceptanceTestNonMainnet locally if my PR affects non-mainnet modules.

Changelog

@matkt
Copy link
Contributor

matkt commented Mar 7, 2023

Tested with @ahamlat . Ethcall fails 1/3 times without the fix and with the fix it works every time so LGTM

Copy link
Contributor

@matkt matkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@garyschulte garyschulte enabled auto-merge (squash) March 7, 2023 15:28
@garyschulte garyschulte merged commit da477e9 into hyperledger:main Mar 7, 2023
garyschulte added a commit to garyschulte/besu that referenced this pull request Apr 10, 2023
* copy layered worldstate fix for eth_call

Signed-off-by: garyschulte <[email protected]>
elenduuche pushed a commit to elenduuche/besu that referenced this pull request Aug 16, 2023
* copy layered worldstate fix for eth_call

Signed-off-by: garyschulte <[email protected]>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
* copy layered worldstate fix for eth_call

Signed-off-by: garyschulte <[email protected]>
@garyschulte garyschulte deleted the bugfix/eth_call branch January 24, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants