build(docker-compose): upgrade to docker compose V2 #2596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outSH
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
|
@petermetz I've tested fabric and sawtooth images by running our example apps (discounted asset trade and electricity trade). For quorum and besu I've used newly build images with our functional tests and all pases. In particular, new image solves https://github.com/hyperledger/cacti/issues/2557 so please push the besu image from this branch to hyperledger ghcr so I can fix them right away :) |
jagpreetsinghsasan
approved these changes
Aug 7, 2023
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Aug 7, 2023
- Update indy validator python dependencies. - Add README chapter on updating python dependencies to simplify this process in the future. - Use pinend ubuntu base image in indy-sdk-cli dockerfile. - Do some minor README improvements and cleanups. Tested with `discounted-asset-trade` (should work without an issue now, at least dockerless one) Depends on: hyperledger-cacti#2596 Signed-off-by: Michal Bajer <[email protected]>
|
Don't merge until besu image is released to ghcr |
- `quorum-multi-party-all-in-one`: use newest `quorum-quorum-dev-quickstart`,
update quorum versions to most recent available. Run ledger as `quorum` user
(required by newer versions). Use docker compose V2 from alpine package registry instead of
V1 from pip.
- `besu-multi-party-all-in-one`: similar changes as for quorum-multi-party-all-in-on.
Fix broken besu private transaction tests.
- `fabric-all-in-one`: Use docker compose V2 from alpine package registry instead of V1 from pip.
- `sawtooth-all-in-one`: Use docker compose V2 from alpine package registry instead of V1 from pip.
Closes: hyperledger-cacti#2593
Closes: hyperledger-cacti#2557
Signed-off-by: Michal Bajer <[email protected]>
outSH
force-pushed
the
update_to_docker_compose_v2_pr
branch
from
a028aa0
to
f520b18
Compare
@petermetz Thanks! I've updated the test files, please review. |
petermetz
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
@outSH Thank you very much! Looks great!
Please take a look at my concurrent PR [1] that also changes the tools/docker/fabric-all-in-one/Dockerfile_v2.x container image file to make sure I didn't destroy any of your intended changes that you made in this PR (I'll make sure that yours go in first because you opened it first).
- I had a slightly different approach to fixing the openssh version conflicts, I'll just go with your solution on that.
- I didn't close any of the ports that were exposed - is that something that you wanted to keep (and if yes why?)
[1] https://github.com/hyperledger/cacti/pull/2599
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Aug 29, 2023
- Update indy validator python dependencies. - Add README chapter on updating python dependencies to simplify this process in the future. - Use pinend ubuntu base image in indy-sdk-cli dockerfile. - Do some minor README improvements and cleanups. - Use pinned fabric-all-in-one versions in discounted-asset-trade. Tested with `discounted-asset-trade` (should work without an issue now, at least dockerless one) Depends on: hyperledger-cacti#2596 Signed-off-by: Michal Bajer <[email protected]>
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Sep 11, 2023
- Update indy validator python dependencies. - Add README chapter on updating python dependencies to simplify this process in the future. - Use pinend ubuntu base image in indy-sdk-cli dockerfile. - Do some minor README improvements and cleanups. - Use pinned fabric-all-in-one versions in discounted-asset-trade. Tested with `discounted-asset-trade` (should work without an issue now, at least dockerless one) Depends on: hyperledger-cacti#2596 Signed-off-by: Michal Bajer <[email protected]>
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Sep 11, 2023
- Update indy validator python dependencies. - Add README chapter on updating python dependencies to simplify this process in the future. - Use pinend ubuntu base image in indy-sdk-cli dockerfile. - Do some minor README improvements and cleanups. - Use pinned fabric-all-in-one versions in discounted-asset-trade. Tested with `discounted-asset-trade` (should work without an issue now, at least dockerless one) Depends on: hyperledger-cacti#2596 Signed-off-by: Michal Bajer <[email protected]>
petermetz
pushed a commit
to outSH/cactus
that referenced
this pull request
Sep 18, 2023
- Update indy validator python dependencies. - Add README chapter on updating python dependencies to simplify this process in the future. - Use pinend ubuntu base image in indy-sdk-cli dockerfile. - Do some minor README improvements and cleanups. - Use pinned fabric-all-in-one versions in discounted-asset-trade. Tested with `discounted-asset-trade` (should work without an issue now, at least dockerless one) Depends on: hyperledger-cacti#2596 Signed-off-by: Michal Bajer <[email protected]>
sandeepnRES
pushed a commit
to sandeepnRES/cacti
that referenced
this pull request
Dec 21, 2023
- Update indy validator python dependencies. - Add README chapter on updating python dependencies to simplify this process in the future. - Use pinend ubuntu base image in indy-sdk-cli dockerfile. - Do some minor README improvements and cleanups. - Use pinned fabric-all-in-one versions in discounted-asset-trade. Tested with `discounted-asset-trade` (should work without an issue now, at least dockerless one) Depends on: hyperledger-cacti#2596 Signed-off-by: Michal Bajer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quorum-multi-party-all-in-one: use newestquorum-quorum-dev-quickstart, update quorum versions to most recent available. Run ledger asquorumuser (required by newer versions). Use docker compose V2 from alpine package registry instead of V1 from pip.besu-multi-party-all-in-one: similar changes as for quorum-multi-party-all-in-on. Fix broken besu private transaction tests.fabric-all-in-one: Use docker compose V2 from alpine package registry instead of V1 from pip.sawtooth-all-in-one: Use docker compose V2 from alpine package registry instead of V1 from pip.Closes: #2593
Closes: #2557