Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(connector-besu): fix flaky private-deploy-contract-from-json-cactus #2557

Closed
petermetz opened this issue Jul 18, 2023 · 1 comment · Fixed by #2596
Closed

test(connector-besu): fix flaky private-deploy-contract-from-json-cactus #2557

petermetz opened this issue Jul 18, 2023 · 1 comment · Fixed by #2596
Assignees
@petermetz
Labels
Besu dependencies Pull requests that update a dependency file Developer_Experience Flaky-Test-Automation Issues related to test stability (which is a long running issue that can never fully be solved) good-first-issue Good for newcomers good-first-issue-400-expert Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. P3 Priority 3: Medium Tests Anything related to tests be that automatic or manual, integration or unit, etc.

Comments

@petermetz
Copy link
Contributor

petermetz commented Jul 18, 2023 •
edited
Loading

Found a flake that has to do with image pulling rate limits most likely.
Attaching the full CI log (from an unrelated PR because this rarely reproduces)

2023-07-18T09-51-04-cacti-flaky-besu-mp-aio-image-pulls-private-deploy-contract-from-json-cactus.test.ts.log

Also set the cactus-plugin-ledger-connector-besu CI job as required in the branch protection rules once again after having fixed this bug (had to set it to optional because otherwise it would block the CI)
@petermetz petermetz added the P3 Priority 3: Medium label Jul 18, 2023
@petermetz petermetz self-assigned this Jul 18, 2023
@petermetz petermetz added good-first-issue Good for newcomers Besu dependencies Pull requests that update a dependency file Developer_Experience Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. good-first-issue-400-expert Flaky-Test-Automation Issues related to test stability (which is a long running issue that can never fully be solved) Tests Anything related to tests be that automatic or manual, integration or unit, etc. labels Jul 18, 2023
@outSH
Copy link
Contributor

outSH commented Aug 4, 2023

@petermetz The name of image consensys/quorum-ethsigner was changed to consensys/ethsigner, that is causing the error

 [2023-08-01T11:19:41.898Z] DEBUG (BesuMpTestLedger): [ghcr.io/hyperledger/cactus-besu-all-in-one-multi-party:2021-08-13--private-tx] 'Pulling ethsignerProxy (consensys/quorum-ethsigner:21.1.0)...\r\n'
    [2023-08-01T11:19:42.510Z] DEBUG (BesuMpTestLedger): [ghcr.io/hyperledger/cactus-besu-all-in-one-multi-party:2021-08-13--private-tx] 'time="2023-08-01T11:19:42.508986912Z" level=error msg="Not continuing with pull after error: errors:\\ndenied: requested access to the resource is denied\\nunauthorized: authentication required\\n"\r\n'

outSH added a commit to outSH/cactus that referenced this issue Aug 4, 2023
@outSH
build(docker-compose): upgrade to docker compose V2
a028aa0 
- `quorum-multi-party-all-in-one`: use newest `quorum-quorum-dev-quickstart`,
    update quorum versions to most recent available. Run ledger as `quorum` user
    (required by newer versions). Use docker compose V2 from alpine package registry instead of
    V1 from pip.
- `besu-multi-party-all-in-one`: similar changes as for quorum-multi-party-all-in-on.
    Fix broken besu private transaction tests.
- `fabric-all-in-one`: Use docker compose V2 from alpine package registry instead of V1 from pip.
- `sawtooth-all-in-one`: Use docker compose V2 from alpine package registry instead of V1 from pip.

Closes: hyperledger-cacti#2593
Closes: hyperledger-cacti#2557

Signed-off-by: Michal Bajer <[email protected]>
@outSH outSH mentioned this issue Aug 4, 2023
Merged
outSH added a commit to outSH/cactus that referenced this issue Aug 9, 2023
@outSH
build(docker-compose): upgrade to docker compose V2
f520b18 
- `quorum-multi-party-all-in-one`: use newest `quorum-quorum-dev-quickstart`,
    update quorum versions to most recent available. Run ledger as `quorum` user
    (required by newer versions). Use docker compose V2 from alpine package registry instead of
    V1 from pip.
- `besu-multi-party-all-in-one`: similar changes as for quorum-multi-party-all-in-on.
    Fix broken besu private transaction tests.
- `fabric-all-in-one`: Use docker compose V2 from alpine package registry instead of V1 from pip.
- `sawtooth-all-in-one`: Use docker compose V2 from alpine package registry instead of V1 from pip.

Closes: hyperledger-cacti#2593
Closes: hyperledger-cacti#2557

Signed-off-by: Michal Bajer <[email protected]>
petermetz pushed a commit that referenced this issue Aug 10, 2023
@outSH @petermetz
build(docker-compose): upgrade to docker compose V2
d84fcd5 
- `quorum-multi-party-all-in-one`: use newest `quorum-quorum-dev-quickstart`,
    update quorum versions to most recent available. Run ledger as `quorum` user
    (required by newer versions). Use docker compose V2 from alpine package registry instead of
    V1 from pip.
- `besu-multi-party-all-in-one`: similar changes as for quorum-multi-party-all-in-on.
    Fix broken besu private transaction tests.
- `fabric-all-in-one`: Use docker compose V2 from alpine package registry instead of V1 from pip.
- `sawtooth-all-in-one`: Use docker compose V2 from alpine package registry instead of V1 from pip.

Closes: #2593
Closes: #2557

Signed-off-by: Michal Bajer <[email protected]>
outSH added a commit to outSH/cactus that referenced this issue Aug 29, 2023
@outSH
build(docker-compose): upgrade to docker compose V2
9b939eb 
- `quorum-multi-party-all-in-one`: use newest `quorum-quorum-dev-quickstart`,
    update quorum versions to most recent available. Run ledger as `quorum` user
    (required by newer versions). Use docker compose V2 from alpine package registry instead of
    V1 from pip.
- `besu-multi-party-all-in-one`: similar changes as for quorum-multi-party-all-in-on.
    Fix broken besu private transaction tests.
- `fabric-all-in-one`: Use docker compose V2 from alpine package registry instead of V1 from pip.
- `sawtooth-all-in-one`: Use docker compose V2 from alpine package registry instead of V1 from pip.

Closes: hyperledger-cacti#2593
Closes: hyperledger-cacti#2557

Signed-off-by: Michal Bajer <[email protected]>
outSH added a commit to outSH/cactus that referenced this issue Sep 28, 2023
@outSH
build(docker-compose): upgrade to docker compose V2
3d32869 
- `quorum-multi-party-all-in-one`: use newest `quorum-quorum-dev-quickstart`,
    update quorum versions to most recent available. Run ledger as `quorum` user
    (required by newer versions). Use docker compose V2 from alpine package registry instead of
    V1 from pip.
- `besu-multi-party-all-in-one`: similar changes as for quorum-multi-party-all-in-on.
    Fix broken besu private transaction tests.
- `fabric-all-in-one`: Use docker compose V2 from alpine package registry instead of V1 from pip.
- `sawtooth-all-in-one`: Use docker compose V2 from alpine package registry instead of V1 from pip.

Closes: hyperledger-cacti#2593
Closes: hyperledger-cacti#2557

Signed-off-by: Michal Bajer <[email protected]>
sandeepnRES pushed a commit to sandeepnRES/cacti that referenced this issue Dec 21, 2023
@outSH @sandeepnRES
build(docker-compose): upgrade to docker compose V2
8d00d54 
- `quorum-multi-party-all-in-one`: use newest `quorum-quorum-dev-quickstart`,
    update quorum versions to most recent available. Run ledger as `quorum` user
    (required by newer versions). Use docker compose V2 from alpine package registry instead of
    V1 from pip.
- `besu-multi-party-all-in-one`: similar changes as for quorum-multi-party-all-in-on.
    Fix broken besu private transaction tests.
- `fabric-all-in-one`: Use docker compose V2 from alpine package registry instead of V1 from pip.
- `sawtooth-all-in-one`: Use docker compose V2 from alpine package registry instead of V1 from pip.

Closes: hyperledger-cacti#2593
Closes: hyperledger-cacti#2557

Signed-off-by: Michal Bajer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermetz petermetz

Labels
Besu dependencies Pull requests that update a dependency file Developer_Experience Flaky-Test-Automation Issues related to test stability (which is a long running issue that can never fully be solved) good-first-issue Good for newcomers good-first-issue-400-expert Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. P3 Priority 3: Medium Tests Anything related to tests be that automatic or manual, integration or unit, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build(docker-compose): upgrade to docker compose V2 outSH/cactus
2 participants
@petermetz @outSH