Skip to content

update contributor lexicon - #92

Merged
aspiers merged 1 commit into
developfrom
update-contributor-lexicon
Jan 21, 2026
Merged

update contributor lexicon#92
aspiers merged 1 commit into
developfrom
update-contributor-lexicon

Conversation

@s-adamantine

@s-adamantine s-adamantine commented Jan 21, 2026

Copy link
Copy Markdown
Contributor

Fixes #85 and #86

Summary by CodeRabbit

  • New Features

    • Added individual contributor profile support with identifiers, display names, and profile images.
  • Changes

    • Restructured contributor data schema for improved profile management and contributor role tracking.
    • Fixed contributor reference inconsistencies across the system.

✏️ Tip: You can customize this high-level summary in your review settings.

@changeset-bot

changeset-bot Bot commented Jan 21, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: bec8e63

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hypercerts-org/lexicon Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Jan 21, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

The pull request restructures the Hypercerts contributor lexicon by renaming org.hypercerts.claim.contribution to org.hypercerts.claim.contributor. It removes the contributors array field and introduces identifier, displayName, and image fields to support individual contributor profiles. The description field is renamed to contributionDescription for clarity, and required fields are simplified to only createdAt. All references and documentation are updated correspondingly.

Changes

Cohort / File(s) Summary
Lexicon Schema Core
lexicons/org/hypercerts/claim/contributor.json
Renamed lexicon from contribution to contributor; relaxed required fields to only createdAt; added identifier, displayName, image fields; renamed description to contributionDescription; removed contributors array
Reference Updates
lexicons/org/hypercerts/claim/activity.json
Updated contributions field reference from org.hypercerts.claim.contribution to org.hypercerts.claim.contributor
Lexicon Definitions
lexicons.md
Added comprehensive lexicon entries for multiple namespaces (app.certified.*, org.hypercerts.*, com.atproto.*, pub.leaflet) including badge, location, activity, contributor, evaluation, evidence, measurement, rights, and funding definitions
Documentation & Diagrams
README.md, ERD.puml
Updated README to reflect new contributor lexicon ID, schema properties, and structure; refreshed ERD entity/dataclass definitions for contributorEntity and contributor with new field representations and updated relationships
Metadata
.changeset/update-contributor-lexicon.md
Changeset documenting minor version bump for lexicon package and summary of lexicon restructuring

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

  • Lexicon review #23: Both PRs rename org.hypercerts.claim.contribution to contributor and update activity references to the new lexicon identifier.
  • clarify different diagram class types #39: Both PRs modify the contributor/contribution entity model in ERD and dataclass definitions with relationship adjustments.
  • add funding receipt schema #37: Both PRs affect the contributor target entity and its usage in funding and claim-related schemas and ERD relationships.

Suggested reviewers

  • aspiers
  • bitbeckers

Poem

🐰 Hops of joy through lexicon halls,
Contributors now stand tall,
New identities, profiles so bright,
Descriptions clear, everything right!
From contribution to contributor's call—
A schema refresh, standing proud for all!

🚥 Pre-merge checks | ✅ 6 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Lexicons Styleguide Compliance ⚠️ Warning The identifier field in lexicons/org/hypercerts/claim/contributor.json is a string type without maxLength or format constraint, violating ATProto styleguide requirements. Add maxLength constraint to identifier field or document the intentional deviation in the field description to comply with styleguide requirements.
✅ Passed checks (6 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'update contributor lexicon' clearly and concisely describes the primary change of restructuring the contributor lexicon schema.
Linked Issues check ✅ Passed All requirements from issue #86 are met: contributors field removed, identifier/displayName/image/role/contributionDescription/startDate/endDate fields added, createdAt is the only required field.
Out of Scope Changes check ✅ Passed All changes directly support the contributor lexicon restructuring objective; no unrelated modifications were introduced.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Lexicon Documentation Sync ✅ Passed The pull request maintains full synchronization between JSON lexicons, README.md, and ERD.puml with correct lexicon ID and all required fields properly defined.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rename org.hypercerts.claim.contribution to contributor

2 participants