Skip to content

Remove bidirectional project-activity link - #67

Merged
aspiers merged 1 commit into
developfrom
fix/remove_projects_from_activities
Jan 19, 2026
Merged

Remove bidirectional project-activity link#67
aspiers merged 1 commit into
developfrom
fix/remove_projects_from_activities

Conversation

@bitbeckers

@bitbeckers bitbeckers commented Jan 19, 2026

Copy link
Copy Markdown
Contributor
  • Remove project field from activity lexicon
  • Update project description to reflect unidirectional relationship
  • Update README documentation to remove project field from activity properties table
  • Update ERD diagrams to remove activity->project relationship arrow
  • Add changeset for minor version bump

Closes #62

Summary by CodeRabbit

  • Chores

    • Added changeset documenting relationship modifications.
  • Refactor

    • Simplified the project-activity relationship from bidirectional to unidirectional. Activities no longer maintain direct project references; only projects reference their associated activities.

✏️ Tip: You can customize this high-level summary in your review settings.

- Remove project field from activity lexicon
- Update project description to reflect unidirectional relationship
- Update README documentation to remove project field from activity properties table
- Update ERD diagrams to remove activity->project relationship arrow
- Add changeset for minor version bump
@bitbeckers
bitbeckers requested a review from aspiers January 19, 2026 20:57
@bitbeckers bitbeckers self-assigned this Jan 19, 2026
@changeset-bot

changeset-bot Bot commented Jan 19, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: b51dd76

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hypercerts-org/lexicon Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Jan 19, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

This PR removes the bidirectional relationship between projects and activities by eliminating the project field from the Activity lexicon. The relationship is now unidirectional, with projects linking to activities via an activities array, while activities no longer reference their parent project.

Changes

Cohort / File(s) Summary
Lexicon Schema Definitions
lexicons/org/hypercerts/claim/activity.json, lexicons/org/hypercerts/claim/project.json
Removed project property from activity record definition; updated project lexicon description to remove reference to one-project-link constraint
Diagram & Documentation
ERD.puml, README.md
Removed activity→project relationship edge and project? field from entity diagram; updated documentation to reflect unidirectional relationship structure
Changeset Metadata
.changeset/remove-bidirectional-project-link.md
New minor version changeset documenting the removal of bidirectional project-activity link

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • aspiers
  • s-adamantine
  • holkexyz

Poem

🐰 One link was two, now two is one,
The activity hops to projects with sun,
No backward glance from claim to deed,
A cleaner path is all we need! 🌱


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Lexicon Documentation Sync ❓ Inconclusive The user requested shell command execution and JSON conversion, but provided no actual verification output or data to analyze. Unable to process shell commands or access files. Provide actual verification output or data to convert to JSON format.
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing the bidirectional link between project and activity in the lexicon, making the relationship unidirectional.
Linked Issues check ✅ Passed The PR successfully addresses issue #62 by removing the project field from the activity lexicon and updating documentation to reflect the unidirectional project-to-activity relationship.
Out of Scope Changes check ✅ Passed All changes are directly related to removing the bidirectional project-activity link as specified in issue #62; no unrelated modifications were introduced.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@aspiers
aspiers merged commit b149015 into develop Jan 19, 2026
3 checks passed
@aspiers
aspiers deleted the fix/remove_projects_from_activities branch January 19, 2026 21:19
@aspiers aspiers mentioned this pull request Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove project from activity claim

2 participants