Increase activity work scope string limit - #212
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
🦋 Changeset detectedLatest commit: 46dee45 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThis PR raises the activity work scope free-text limit (maxGraphemes 100 → 1,000; maxLength 1,000 → 10,000), records a minor changeset describing the change and byte cap, updates the schema doc generator to show property comments, and regenerates SCHEMAS.md with new constraint metadata. ChangesWork Scope String Limit and Schema Documentation Update
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 6 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.changeset/increase-workscope-string-limit.md (1)
5-5: ⚡ Quick winInclude the 4,000-character limit in the changeset note.
The schema change updates both grapheme and character limits; documenting both here avoids ambiguous release notes for consumers.
Proposed wording
-Increase the free-form activity work scope string limit to 1,000 graphemes. +Increase the free-form activity work scope string limit to 1,000 graphemes (maxLength: 4,000 characters).🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.changeset/increase-workscope-string-limit.md at line 5, Update the changeset note so it documents both limits: change the single sentence "Increase the free-form activity work scope string limit to 1,000 graphemes." to explicitly state the grapheme and character limits (e.g., "Increase the free-form activity work scope string limit to 1,000 graphemes (up to 4,000 characters)"). Ensure the new wording appears in the .changeset/increase-workscope-string-limit.md content so release notes clearly convey both the grapheme and 4,000-character constraints.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@lexicons/org/hypercerts/claim/activity.json`:
- Around line 150-151: The schema changes increased workScopeString.scope limits
in lexicons/org/hypercerts/claim/activity.json (now "maxLength": 4000,
"maxGraphemes": 1000); update SCHEMAS.md to reflect these new constraints for
the workScopeString.scope field, add the new numeric limits and any
example/description text that references the previous sizes, and ensure the
SCHEMAS.md entry matches the lexicon JSON exactly so field-level docs won’t
drift.
---
Nitpick comments:
In @.changeset/increase-workscope-string-limit.md:
- Line 5: Update the changeset note so it documents both limits: change the
single sentence "Increase the free-form activity work scope string limit to
1,000 graphemes." to explicitly state the grapheme and character limits (e.g.,
"Increase the free-form activity work scope string limit to 1,000 graphemes (up
to 4,000 characters)"). Ensure the new wording appears in the
.changeset/increase-workscope-string-limit.md content so release notes clearly
convey both the grapheme and 4,000-character constraints.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: ea266de5-ca9f-417b-8833-58495c2420d0
📒 Files selected for processing (3)
.changeset/increase-workscope-string-limit.mdREADME.mdlexicons/org/hypercerts/claim/activity.json
24f9022 to
cdefa68
Compare
|
See corresponding linear ticket for research on who used it. |
aspiers
left a comment
There was a problem hiding this comment.
I think I'm in favour of this in principle, but feel we may need to do a little more work on the community-wide communications. Let's discuss quickly in the call?
2b372dd to
76a46bc
Compare
76a46bc to
ecfad2d
Compare
|
increased max length to 10,000 following the guidelines from atproto
From style guide |
ecfad2d to
871608f
Compare
Summary
org.hypercerts.claim.activity#workScopeString.scopeto 1,000 graphemesmaxLengthto 4,000 bytesSCHEMAS.mdgeneration so field constraints on schema defs are included and don’t driftTests
npm run checkSummary by CodeRabbit