feat: add #text variant to funding receipt from/to unions - #199
Merged
Conversation
The from/to unions now also accept a #text object wrapping a free-text string (maxLength 2048) for names, wallet addresses, or any other identifier that isn't a DID or record reference. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 03a75e1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
satyam-mishra-pce
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#textdef (free-text string, maxLength 2048) to thefrom/tounion refs infunding.receipt#text(free-text string e.g. name, wallet address),app.certified.defs#did, andcom.atproto.repo.strongRefWhy
The
from/tofields currently only accept DIDs and strongRefs. This doesn't cover cases where the sender/recipient is identified by a plain string — a display name, a wallet address, an organization name, etc. Adding#textrestores that flexibility as a typed union variant.Relates to #186.
Test plan
npm run checkpasses (gen-api, lint, typecheck, build, test)toandfromas#textpass🤖 Generated with Claude Code