refactor: move evaluation and attachment to context namespace - #154
Conversation
…mespace Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 5a6e619 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThis pull request relocates the attachment and evaluation lexicon definitions from the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
Poem
Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error, 1 warning)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@coderabbitai evaluation subject is deliberately untyped since we want anything to be evaluated potentially. Also the lexicon style guide does not say anything about maxLength for arrays, only strings. |
|
Tip For best results, initiate chat on the files or code changes.
I've noted both of these points for future reviews. ✏️ Learnings added
🧠 Learnings used |
Summary
org.hypercerts.claim.evaluation→org.hypercerts.context.evaluationorg.hypercerts.claim.attachment→org.hypercerts.context.attachmentTest plan
npm run checkpasses (gen-api, lint, typecheck, build, test)🤖 Generated with Claude Code
Summary by CodeRabbit
Refactor
Chores