Skip to content

Expand locationType knownValues from Location Protocol spec - #136

Merged
aspiers merged 3 commits into
developfrom
copilot/add-known-values-locationtype
Feb 12, 2026
Merged

Expand locationType knownValues from Location Protocol spec#136
aspiers merged 3 commits into
developfrom
copilot/add-known-values-locationtype

Conversation

Copilot AI commented Feb 12, 2026

Copy link
Copy Markdown
Contributor

The locationType field in app.certified.location only listed coordinate-decimal and geojson-point as known values, missing the broader set defined in the Location Protocol location type registry.

Changes

  • lexicons/app/certified/location.json — Added geojson, h3, geohash, wkt, address, scaledCoordinates to knownValues; updated description to link to the official spec registry
  • README.md — Updated locationType docs to list all known values and link to the spec
  • SCHEMAS.md — Auto-regenerated
"locationType": {
  "type": "string",
  "description": "An identifier for the format of the location data (e.g., coordinate-decimal, geojson-point). See the Location Protocol spec for the full registry: https://spec.decentralizedgeo.org/specification/location-types/#location-type-registry",
  "knownValues": [
    "coordinate-decimal",
    "geojson-point",
    "geojson",
    "h3",
    "geohash",
    "wkt",
    "address",
    "scaledCoordinates"
  ],
  "maxLength": 20
}

Per the ATProto lexicon spec, knownValues are suggested/common values — the field remains open to custom values.

Original prompt

This section details on the original issue you should resolve

<issue_title>app.certified.location locationType should have a richer set of knownValues</issue_title>
<issue_description>

"knownValues": ["coordinate-decimal", "geojson-point"],

Is the certified location not supporting anything but a point? I would remove known values if you are not sure what geospatial entities to expect because it confuses AI agents and humans.</issue_description>

<agent_instructions>Create a PR adding the other locationType known values listed in that commit: DecentralizedGeo/location-protocol-spec@c845ad0#diff-21d7b47d2854fa3120e2803cde9a27ab9a76ecd97fdbe2af1288828d62769c20</agent_instructions>

Comments on the Issue (you are @copilot in this section)

@aspiers As @s-adamantine mentioned earlier, https://atproto.com/specs/lexicon#string says:

knownValues (array of strings, optional): a set of suggested or common values for this field. Values are not limited to this set (aka, not a closed enum).

So these are not the only two values allowed.

That said, I agree it makes sense to include more known values for legibility, especially ones such as geojson polygons which are likely to be commonly used. So we can use this issue to track that.</comment_new>
<comment_new>@holkexyz
Let's add at least the geojson-polygon (I don't know if there are others that are commonly used like "geojson-multipolygon").

Is this where users could also just add their region, postal code or a name of a site? Or do we want to avoid that?</comment_new>
<comment_new>@aspiers
I'm checking with @johnx25bd on this.</comment_new>
<comment_new>@aspiers
@copilot Can you create a PR adding the other locationType known values listed in that commit?</comment_new>


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@changeset-bot

changeset-bot Bot commented Feb 12, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 2fbaada

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hypercerts-org/lexicon Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

…ss, scaledCoordinates

Co-authored-by: aspiers <100738+aspiers@users.noreply.github.com>
Copilot AI changed the title [WIP] Add richer set of knownValues for locationType Expand locationType knownValues from Location Protocol spec Feb 12, 2026
Copilot AI requested a review from aspiers February 12, 2026 02:35
…nd changeset

Co-authored-by: aspiers <100738+aspiers@users.noreply.github.com>
@aspiers
aspiers marked this pull request as ready for review February 12, 2026 03:01
Copilot AI review requested due to automatic review settings February 12, 2026 03:01
@aspiers
aspiers merged commit a41d4aa into develop Feb 12, 2026
8 checks passed
@aspiers
aspiers deleted the copilot/add-known-values-locationtype branch February 12, 2026 03:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Expands the documented/suggested locationType values for app.certified.location to align with the broader Location Protocol registry, improving schema legibility for clients and agents.

Changes:

  • Expanded locationType.knownValues in the certified location lexicon and linked to the official registry.
  • Updated README docs to list the expanded set of known values and reference the spec.
  • Regenerated SCHEMAS.md and added a Changesets entry for release versioning.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
lexicons/app/certified/location.json Extends locationType.knownValues and updates description to reference the Location Protocol registry.
README.md Documents the expanded locationType options and adds spec link in the location record docs.
SCHEMAS.md Regenerated schema documentation reflecting the updated lexicon description/known values.
package-lock.json Introduces peer: true flags on several packages (appears unrelated to the lexicon/doc changes).
.changeset/expand-location-type-known-values.md Adds a Changesets entry to release the update as a minor version bump.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md
lpVersion: "1.0", // Location Protocol version
srs: "http://www.opengis.net/def/crs/OGC/1.3/CRS84", // Spatial Reference System
locationType: "coordinate-decimal", // or "geojson-point"
locationType: "coordinate-decimal", // or "geojson-point", "geojson", "h3", "geohash", "wkt", "address", etc.

Copilot AI Feb 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this example, locationType is set to "coordinate-decimal" but the location.uri points to a .geojson resource. This is internally inconsistent and could mislead users; update the example so the locationType matches the referenced/embedded location format (e.g., use geojson/geojson-point for a GeoJSON URI, or change the URI to a coordinate-decimal resource).

Suggested change
locationType: "coordinate-decimal", // or "geojson-point", "geojson", "h3", "geohash", "wkt", "address", etc.
locationType: "geojson", // or "coordinate-decimal", "geojson-point", "h3", "geohash", "wkt", "address", etc.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

app.certified.location locationType should have a richer set of knownValues

3 participants