Expand locationType knownValues from Location Protocol spec - #136
Conversation
🦋 Changeset detectedLatest commit: 2fbaada The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…ss, scaledCoordinates Co-authored-by: aspiers <100738+aspiers@users.noreply.github.com>
…nd changeset Co-authored-by: aspiers <100738+aspiers@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Expands the documented/suggested locationType values for app.certified.location to align with the broader Location Protocol registry, improving schema legibility for clients and agents.
Changes:
- Expanded
locationType.knownValuesin the certified location lexicon and linked to the official registry. - Updated README docs to list the expanded set of known values and reference the spec.
- Regenerated
SCHEMAS.mdand added a Changesets entry for release versioning.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
lexicons/app/certified/location.json |
Extends locationType.knownValues and updates description to reference the Location Protocol registry. |
README.md |
Documents the expanded locationType options and adds spec link in the location record docs. |
SCHEMAS.md |
Regenerated schema documentation reflecting the updated lexicon description/known values. |
package-lock.json |
Introduces peer: true flags on several packages (appears unrelated to the lexicon/doc changes). |
.changeset/expand-location-type-known-values.md |
Adds a Changesets entry to release the update as a minor version bump. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| lpVersion: "1.0", // Location Protocol version | ||
| srs: "http://www.opengis.net/def/crs/OGC/1.3/CRS84", // Spatial Reference System | ||
| locationType: "coordinate-decimal", // or "geojson-point" | ||
| locationType: "coordinate-decimal", // or "geojson-point", "geojson", "h3", "geohash", "wkt", "address", etc. |
There was a problem hiding this comment.
In this example, locationType is set to "coordinate-decimal" but the location.uri points to a .geojson resource. This is internally inconsistent and could mislead users; update the example so the locationType matches the referenced/embedded location format (e.g., use geojson/geojson-point for a GeoJSON URI, or change the URI to a coordinate-decimal resource).
| locationType: "coordinate-decimal", // or "geojson-point", "geojson", "h3", "geohash", "wkt", "address", etc. | |
| locationType: "geojson", // or "coordinate-decimal", "geojson-point", "h3", "geohash", "wkt", "address", etc. |
The
locationTypefield inapp.certified.locationonly listedcoordinate-decimalandgeojson-pointas known values, missing the broader set defined in the Location Protocol location type registry.Changes
lexicons/app/certified/location.json— Addedgeojson,h3,geohash,wkt,address,scaledCoordinatestoknownValues; updated description to link to the official spec registryREADME.md— UpdatedlocationTypedocs to list all known values and link to the specSCHEMAS.md— Auto-regeneratedPer the ATProto lexicon spec,
knownValuesare suggested/common values — the field remains open to custom values.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.