Skip to content

P3: fix(demo): show user-friendly authentication errors - #226

Draft
aspiers wants to merge 1 commit into
mainfrom
split-pr165/friendly-demo-errors
Draft

P3: fix(demo): show user-friendly authentication errors#226
aspiers wants to merge 1 commit into
mainfrom
split-pr165/friendly-demo-errors

Conversation

@aspiers

@aspiers aspiers commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Summary

Translate known demo-client authentication failures into plain-language guidance instead of exposing developer-oriented wording such as instructions to check server logs.

Changes

  • Map known callback and session failures to user-facing messages
  • Preserve a neutral fallback for unknown failures
  • Document the copy change with a changeset

Testing

  • pnpm format:check
  • pnpm lint
  • pnpm typecheck
  • pnpm test
  • pnpm test:coverage

Screenshots

Before: the demo exposed provider/PAR terminology and told end users to inspect server logs.

Before: technical demo error

After: the message gives an immediate retry action and a support escalation path without exposing implementation details.

After: actionable demo sign-in error

Notes

@vercel

vercel Bot commented Jul 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
epds-demo Ready Ready Preview Jul 30, 2026 3:55pm

Request Review

@changeset-bot

changeset-bot Bot commented Jul 30, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d1276e0

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e1b58581-9b25-4d78-aaeb-caee2908c2fd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@railway-app

railway-app Bot commented Jul 30, 2026

Copy link
Copy Markdown

🚅 Deployed to the ePDS-pr-226 environment in ePDS

Service Status Web Updated (UTC)
@certified-app/demo ✅ Success (View Logs) Web Jul 30, 2026 at 4:19 pm
@certified-app/demo untrusted ✅ Success (View Logs) Web Jul 30, 2026 at 4:18 pm
@certified-app/auth-service ✅ Success (View Logs) Web Jul 30, 2026 at 1:42 pm
@certified-app/pds-core ✅ Success (View Logs) Web Jul 30, 2026 at 1:42 pm

@coveralls-official

coveralls-official Bot commented Jul 30, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 30559000234

Coverage increased (+0.03%) to 57.312%

Details

  • Coverage increased (+0.03%) from the base build.
  • Patch coverage: 2 of 2 lines across 1 file are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 3071
Covered Lines: 1755
Line Coverage: 57.15%
Relevant Branches: 1914
Covered Branches: 1102
Branch Coverage: 57.58%
Branches in Coverage %: Yes
Coverage Strength: 6.05 hits per line

💛 - Coveralls

@aspiers aspiers changed the title fix(demo): show user-friendly authentication errors P3: fix(demo): show user-friendly authentication errors Jul 30, 2026
Comment thread packages/demo/src/app/components/LoginForm.tsx Outdated
Comment thread packages/demo/src/app/components/LoginForm.tsx Outdated
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant