Skip to content

Align Stock PDS login-complete redirect message card - #169

Merged
aspiers merged 2 commits into
mainfrom
karma/hyper-395-align-the-login-complete-page
May 13, 2026
Merged

Align Stock PDS login-complete redirect message card#169
aspiers merged 2 commits into
mainfrom
karma/hyper-395-align-the-login-complete-page

Conversation

@Kzoeps

@Kzoeps Kzoeps commented May 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Align the upstream OAuth login-complete redirect message card with the page title on desktop without moving form-heavy consent screens.
  • Refactor demo theme CSS generation to reduce duplication while preserving themed provider/auth-service styling.
  • Add primary button text color support so amber-themed demo buttons keep readable contrast.
  • Add demo theme coverage and ratchet Vitest coverage thresholds

Previously

image

Updated

image

Driveby amber theme fix

image image

Summary by CodeRabbit

Release Notes

  • Bug Fixes

    • Fixed vertical alignment of "You are being redirected…" message card on the login completion screen to properly align with the page title.
  • New Features

    • Enhanced theming system to support customizable primary button text colors, allowing button styling to adapt to selected themes across the application.
  • Tests

    • Added comprehensive test suite for theme resolution validation.
  • Chores

    • Updated test coverage thresholds.

Review Change Stack

@vercel

vercel Bot commented May 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
epds-demo Ready Ready Preview, Comment May 13, 2026 10:29am

Request Review

@changeset-bot

changeset-bot Bot commented May 13, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f221800

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented May 13, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@Kzoeps has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 46 minutes and 4 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d884aae1-d8b6-4fa8-9242-6b80a3a0b836

📥 Commits

Reviewing files that changed from the base of the PR and between 3531459 and f221800.

📒 Files selected for processing (7)
  • packages/demo/src/__tests__/theme.test.ts
  • packages/demo/src/app/components/LoginForm.tsx
  • packages/demo/src/app/components/PageShell.tsx
  • packages/demo/src/app/components/SignInButton.tsx
  • packages/demo/src/app/welcome/page.tsx
  • packages/demo/src/lib/theme.ts
  • vitest.config.ts
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 60.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Add login complete preview' accurately reflects the main objective of the PR, which adds a new preview route for the login-complete redirect state.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch karma/hyper-395-align-the-login-complete-page

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@railway-app

railway-app Bot commented May 13, 2026

Copy link
Copy Markdown

🚅 Deployed to the ePDS-pr-169 environment in ePDS

Service Status Web Updated (UTC)
@certified-app/demo untrusted ✅ Success (View Logs) Web May 13, 2026 at 10:14 am
@certified-app/demo ✅ Success (View Logs) Web May 13, 2026 at 10:14 am
@certified-app/pds-core ✅ Success (View Logs) Web May 13, 2026 at 9:13 am
@certified-app/auth-service ✅ Success (View Logs) Web May 13, 2026 at 7:02 am

@coveralls-official

coveralls-official Bot commented May 13, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 25793413318

Coverage increased (+0.3%) to 55.82%

Details

  • Coverage increased (+0.3%) from the base build.
  • Patch coverage: 5 of 5 lines across 1 file are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 2938
Covered Lines: 1635
Line Coverage: 55.65%
Relevant Branches: 1804
Covered Branches: 1012
Branch Coverage: 56.1%
Branches in Coverage %: Yes
Coverage Strength: 5.73 hits per line

💛 - Coveralls

@blacksmith-sh

This comment has been minimized.

@Kzoeps
Kzoeps force-pushed the karma/hyper-395-align-the-login-complete-page branch from 9654595 to cc65707 Compare May 13, 2026 09:11
@railway-app
railway-app Bot temporarily deployed to ePDS / ePDS-pr-169 May 13, 2026 09:11 Destroyed
@railway-app
railway-app Bot temporarily deployed to ePDS / ePDS-pr-169 May 13, 2026 09:27 Destroyed
@railway-app
railway-app Bot temporarily deployed to ePDS / ePDS-pr-169 May 13, 2026 09:49 Destroyed
@Kzoeps

Kzoeps commented May 13, 2026

Copy link
Copy Markdown
Contributor Author

(reply generated by gpt-5.5)

Fixed in 7a5ce6e. Refactored the duplicated demo theme CSS generation so the ocean and amber themes share one selector builder while preserving the emitted styling.

@Kzoeps

Kzoeps commented May 13, 2026

Copy link
Copy Markdown
Contributor Author

(reply generated by gpt-5.5)

Addressed review/status comments:

Coveralls #169 (comment): fixed locally by adding focused theme.ts coverage; pnpm test:coverage now passes with theme.ts at 100% statements/lines, and thresholds were ratcheted. Pending commit/push for bot verification.

SonarCloud #169 (comment): fixed locally by converting the escaped Tailwind selector templates to String.raw. pnpm lint and pnpm typecheck pass. Pending commit/push for bot verification.

Blacksmith #169 (comment): stale per maintainer note; current PR checks show the normal test job passing, so no code change made for that comment.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.changeset/align-login-complete-card.md:
- Line 2: The changeset frontmatter uses the wrong package name 'ePDS'; update
the frontmatter in .changeset/align-login-complete-card.md to reference the
actual package name `@certified-app/pds-core` so the changeset applies to
packages/pds-core; replace 'ePDS' with '@certified-app/pds-core' in the file's
frontmatter entry.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d7017338-507f-47fd-93fd-50f6650b927b

📥 Commits

Reviewing files that changed from the base of the PR and between cb904e9 and 3531459.

📒 Files selected for processing (9)
  • .changeset/align-login-complete-card.md
  • packages/demo/src/__tests__/theme.test.ts
  • packages/demo/src/app/components/LoginForm.tsx
  • packages/demo/src/app/components/PageShell.tsx
  • packages/demo/src/app/components/SignInButton.tsx
  • packages/demo/src/app/welcome/page.tsx
  • packages/demo/src/lib/theme.ts
  • packages/pds-core/src/lib/default-branding.ts
  • vitest.config.ts

Comment thread .changeset/align-login-complete-card.md
@Kzoeps
Kzoeps marked this pull request as ready for review May 13, 2026 10:24

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@Kzoeps
Kzoeps requested review from aspiers and s-adamantine May 13, 2026 10:27
@Kzoeps

Kzoeps commented May 13, 2026

Copy link
Copy Markdown
Contributor Author

@coderabbitai please review

@coderabbitai

coderabbitai Bot commented May 13, 2026

Copy link
Copy Markdown

The PR description images show:

  • Image 1: The updated "Login complete" page — the "You are being redirected..." card is now horizontally aligned with the bold "Login complete" title, both centered vertically on the page.
  • Image 2: A Firefox devtools capture of the live OAuth flow on the Railway preview deployment, showing three network requests (consent 200, redirect?redirect_mode 303, callback?state=... pending) with network blocking rules active to capture the redirect state.

@Kzoeps: Sure, I'll kick off a review of this PR now!

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@Kzoeps
Kzoeps force-pushed the karma/hyper-395-align-the-login-complete-page branch from 3531459 to f221800 Compare May 13, 2026 10:28
@railway-app
railway-app Bot temporarily deployed to ePDS / ePDS-pr-169 May 13, 2026 10:28 Destroyed
@sonarqubecloud

Copy link
Copy Markdown

@aspiers
aspiers added this pull request to the merge queue May 13, 2026
Merged via the queue into main with commit 49a0579 May 13, 2026
15 checks passed
@aspiers
aspiers deleted the karma/hyper-395-align-the-login-complete-page branch May 13, 2026 11:53
@Kzoeps Kzoeps changed the title Add login complete preview Align Stock PDS login-complete redirect message card May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants