143 oauth enrichment cover all pages hide handles in random mode explain via tooltip merge - #157
Closed
Kzoeps wants to merge 10 commits into
Conversation
…ent-cover-all-pages-hide-handles-in-random-mode-explain-via-tooltip-merge
…ndles-in-random-mode-explain-via-tooltip-merge
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: cc54b3e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
🚅 Deployed to the ePDS-pr-157 environment in ePDS
|
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (25)
📝 WalkthroughWalkthroughThis PR enriches account presentation in OAuth consent and account-chooser flows by adding email as a primary identifier, refining handle visibility in random-mode flows to use accessible descriptions, introducing a consent-screen identity tooltip, threading ChangesAccount Enrichment, Handle-Mode Threading, and Login Form Readiness
Sequence DiagramsequenceDiagram
actor User
participant Browser
participant AuthService as Auth Service
participant PDS as PDS Core
participant OAuthServer as OAuth Server
User->>Browser: Navigate to app
Browser->>AuthService: GET /auth/login-page
AuthService-->>Browser: Render form (data-epds-login-ready="false", disabled button)
Browser->>Browser: Initialize form<br/>(setup handlers, wait for readiness)
Browser->>Browser: Set data-epds-login-ready="true"<br/>Enable submit button
User->>Browser: Submit email OTP form
Browser->>AuthService: POST /auth/send-otp
AuthService-->>Browser: Render OTP entry form
User->>Browser: Submit OTP
Browser->>AuthService: POST /auth/complete (with auth_flow cookie)
AuthService->>AuthService: Resolve identity via email<br/>(handle-mode from flow)
AuthService-->>Browser: Redirect to /oauth/epds-callback<br/>(signed: epds_handle_mode)
Browser->>PDS: GET /oauth/epds-callback<br/>(verify HMAC signature)
PDS->>OAuthServer: Redirect to /oauth/authorize<br/>(with epds_handle_mode)
OAuthServer-->>Browser: Render account chooser<br/>(enriched: email labels, aria-describedby)
User->>Browser: Select account
Browser->>OAuthServer: Submit chooser
OAuthServer-->>Browser: Render consent screen<br/>(enriched: email primary,<br/>identity-tooltip with handle/email)
User->>Browser: Grant consent
Browser->>OAuthServer: Complete OAuth flow
OAuthServer-->>Browser: Redirect to app with authorization
Estimated Code Review Effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly Related Issues
Possibly Related PRs
Suggested Reviewers
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Coverage Report for CI Build 25385992445Coverage increased (+2.6%) to 58.098%Details
Uncovered Changes
Coverage Regressions2 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Release Notes
New Features
Bug Fixes