Skip to content

Fix: Sheet overlay - TypeError: Cannot redefine property: class#1599

Closed
ekaya97 wants to merge 1 commit intohuntabyte:nextfrom
ekaya97:patch-1
Closed

Fix: Sheet overlay - TypeError: Cannot redefine property: class#1599
ekaya97 wants to merge 1 commit intohuntabyte:nextfrom
ekaya97:patch-1

Conversation

@ekaya97
Copy link
Copy Markdown

@ekaya97 ekaya97 commented Jan 7, 2025

Describe issue
Sheet overlay has a bug and causes site to crash.

Using
npm info using npm@10.9.0
npm info using node@v22.12.0
"bits-ui": "^1.0.0-next.77"
"svelte": "^5.0.0",
shadcn-svelte@next

Error stack
TypeError: Cannot redefine property: class
at defineProperty ()
at chunk-DU37TRKP.js?v=a56227c5:3578:5
at Array.forEach ()
at Module.create_custom_element (chunk-DU37TRKP.js?v=a56227c5:3577:11)
at sheet-overlay.svelte:6:23

Proposal for fix
remove export { className as class }; in line 11
class is already exported using $props()

Changes made
Removed the export line.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 7, 2025

⚠️ No Changeset found

Latest commit: 31bace5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ekaya97 ekaya97 changed the title Update sheet-overlay.svelte Fix: Sheet overlay - TypeError: Cannot redefine property: class Jan 7, 2025
@huntabyte
Copy link
Copy Markdown
Owner

We can just remove it altogether, no need to simply comment it out!

@AdrianGonz97
Copy link
Copy Markdown
Collaborator

superseded by #2051

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants