Fix: Sheet overlay - TypeError: Cannot redefine property: class#1599
Closed
ekaya97 wants to merge 1 commit intohuntabyte:nextfrom
Closed
Fix: Sheet overlay - TypeError: Cannot redefine property: class#1599ekaya97 wants to merge 1 commit intohuntabyte:nextfrom
ekaya97 wants to merge 1 commit intohuntabyte:nextfrom
Conversation
|
Owner
|
We can just remove it altogether, no need to simply comment it out! |
Collaborator
|
superseded by #2051 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe issue
Sheet overlay has a bug and causes site to crash.
Using
npm info using npm@10.9.0
npm info using node@v22.12.0
"bits-ui": "^1.0.0-next.77"
"svelte": "^5.0.0",
shadcn-svelte@next
Error stack
TypeError: Cannot redefine property: class
at defineProperty ()
at chunk-DU37TRKP.js?v=a56227c5:3578:5
at Array.forEach ()
at Module.create_custom_element (chunk-DU37TRKP.js?v=a56227c5:3577:11)
at sheet-overlay.svelte:6:23
Proposal for fix
remove
export { className as class };in line 11class is already exported using $props()
Changes made
Removed the export line.