Skip to content

Hotfix CI with dev dependencies: xfail test_training_vlm_and_liger #4777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
albertvillanova merged 1 commit into from
Jan 6, 2026
Merged

Hotfix CI with dev dependencies: xfail test_training_vlm_and_liger #4777

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tests/test_grpo_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1597,6 +1597,12 @@ def reward_func(completions, **kwargs):
new_param = trainer.model.get_parameter(n)
assert not torch.equal(param, new_param), f"Parameter {n} has not changed."

@pytest.mark.xfail(
Version(transformers.__version__).is_devrelease, # Tests with dev dependencies
reason="Blocked by upstream liger-kernel bug (linkedin/Liger-Kernel#960); "
"fixed by linkedin/Liger-Kernel#966 but not yet released (>0.6.4 required)",
strict=True,
)
@pytest.mark.parametrize(
"model_id",
[
Expand Down
Loading