Skip to content

Comments

Hotfix CI with dev dependencies: xfail test_training_vlm_and_liger#4777

Merged
albertvillanova merged 1 commit intohuggingface:mainfrom
albertvillanova:hotfix-4601
Jan 6, 2026
Merged

Hotfix CI with dev dependencies: xfail test_training_vlm_and_liger#4777
albertvillanova merged 1 commit intohuggingface:mainfrom
albertvillanova:hotfix-4601

Conversation

@albertvillanova
Copy link
Member

@albertvillanova albertvillanova commented Jan 6, 2026

Hotfix CI with dev dependencies: xfail tests/test_grpo_trainer.py::TestGRPOTrainer::test_training_vlm_and_liger[trl-internal-testing/tiny-Qwen2_5_VLForConditionalGeneration]

AttributeError: 'Qwen2_5_VLForConditionalGeneration' object has no attribute 'language_model'

This PR marks test as expected to fail until the upstream fix in liger-kernel is released:

Hotfix for:

The issue appeared in CI tests with dev dependencies after the merge of this PR in transformers:

Testing improvements:

  • Added an xfail marker to the test parameterization for model versions, causing the test to be expected to fail when running with a development release of the transformers library, due to a known issue in the upstream liger-kernel dependency. The marker includes a clear reason and references the relevant upstream issues and required version for resolution.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@albertvillanova
Copy link
Member Author

CI is completely green! 😅

Copy link
Member

@qgallouedec qgallouedec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is completely green! 😅

Nicely done!! For how long? 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI fails with dev dependencies: AttributeError: 'Qwen2_5_VLForConditionalGeneration' object has no attribute 'language_model'

3 participants