-
Notifications
You must be signed in to change notification settings - Fork 32.4k
Tapas v4 (tres) #9117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Tapas v4 (tres) #9117
Changes from all commits
Commits
Show all changes
71 commits
Select commit
Hold shift + click to select a range
450d9b9
First commit: adding all files from tapas_v3
5299d57
Fix multiple bugs including soft dependency and new structure of the …
fb4bf22
Improve testing by adding torch_device to inputs and adding dependenc…
71c87ae
Use Python 3 inheritance rather than Python 2
da846e6
First draft model cards of base sized models
086be40
Remove model cards as they are already on the hub
122923d
Fix multiple bugs with integration tests
eb99dc7
All model integration tests pass
b411f87
Remove print statement
65003b4
Add test for convert_logits_to_predictions method of TapasTokenizer
57a66b2
Incorporate suggestions by Google authors
dc6e866
Fix remaining tests
LysandreJik 6956f2e
Change position embeddings sizes to 512 instead of 1024
2bc720a
Comment out positional embedding sizes
89a06d4
Update PRETRAINED_VOCAB_FILES_MAP and PRETRAINED_POSITIONAL_EMBEDDING…
29af69a
Added more model names
2f1540d
Fix truncation when no max length is specified
LysandreJik 4c976c5
Disable torchscript test
LysandreJik 3092927
Make style & make quality
13e9e26
Quality
LysandreJik ee28e0d
Address CI needs
LysandreJik f4eae58
Test the Masked LM model
LysandreJik 57aa4fe
Fix the masked LM model
LysandreJik c67071b
Truncate when overflowing
LysandreJik 729cf9b
More much needed docs improvements
4e8df2d
Fix some URLs
d9ec541
Some more docs improvements
0e06a3d
Test PyTorch scatter
LysandreJik c05e5fd
Set to slow + minify
LysandreJik b6a955b
Merge pull request #8 from huggingface/tapas_v4_final
NielsRogge 054f023
Calm flake8 down
LysandreJik 0c66d17
Merge pull request #9 from huggingface/tapas_v4_final
NielsRogge 48b7238
First commit: adding all files from tapas_v3
899cf12
Fix multiple bugs including soft dependency and new structure of the …
fbab808
Improve testing by adding torch_device to inputs and adding dependenc…
b791902
Use Python 3 inheritance rather than Python 2
a5b94fe
First draft model cards of base sized models
7aadce5
Remove model cards as they are already on the hub
2d086b4
Fix multiple bugs with integration tests
0f52b35
All model integration tests pass
8d28fc2
Remove print statement
21584c4
Add test for convert_logits_to_predictions method of TapasTokenizer
54110a4
Incorporate suggestions by Google authors
4c3c6c3
Fix remaining tests
LysandreJik 4f97d15
Change position embeddings sizes to 512 instead of 1024
c5466d9
Comment out positional embedding sizes
cf885ec
Update PRETRAINED_VOCAB_FILES_MAP and PRETRAINED_POSITIONAL_EMBEDDING…
7280993
Added more model names
e7f0771
Fix truncation when no max length is specified
LysandreJik 6a91097
Disable torchscript test
LysandreJik 29d2a32
Make style & make quality
5c74867
Quality
LysandreJik f190fa3
Address CI needs
LysandreJik 5260c5a
Test the Masked LM model
LysandreJik e041dec
Fix the masked LM model
LysandreJik 7ee545d
Truncate when overflowing
LysandreJik b252797
More much needed docs improvements
f1a10df
Fix some URLs
89f5229
Some more docs improvements
9545e80
Add add_pooling_layer argument to TapasModel
830cb08
Fix merge conflicts
ee09c36
Fix issue in docs + fix style and quality
b4f6b6c
Clean up conversion script and add task parameter to TapasConfig
c4c94d1
Revert the task parameter of TapasConfig
e7d0ce9
Improve conversion script and add test for absolute position embeddings
NielsRogge fce7b98
Improve conversion script and add test for absolute position embeddings
NielsRogge 8ba021c
Fix bug with reset_position_index_per_cell arg of the conversion cli
NielsRogge c9d5f5b
Add notebooks to the examples directory and fix style and quality
NielsRogge 1acb830
Apply suggestions from code review
LysandreJik 74ad7e9
Move from `nielsr/` to `google/` namespace
LysandreJik d63e8ab
Apply Sylvain's comments
LysandreJik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -50,6 +50,7 @@ jobs: | |
| pip install --upgrade pip | ||
| pip install .[torch,sklearn,testing,onnxruntime,sentencepiece] | ||
| pip install git+https://github.com/huggingface/datasets | ||
| pip install pandas torch-scatter -f https://pytorch-geometric.com/whl/torch-$(python -c "import torch; print(''.join(torch.__version__)")+$(python -c "import torch; print(''.join(torch.version.cuda.split('.')))").html | ||
|
|
||
| - name: Are GPUs recognized by our DL frameworks | ||
| run: | | ||
|
|
@@ -187,6 +188,7 @@ jobs: | |
| pip install --upgrade pip | ||
| pip install .[torch,sklearn,testing,onnxruntime,sentencepiece] | ||
| pip install git+https://github.com/huggingface/datasets | ||
| pip install pandas torch-scatter -f https://pytorch-geometric.com/whl/torch-$(python -c "import torch; print(''.join(torch.__version__)")+$(python -c "import torch; print(''.join(torch.version.cuda.split('.')))").html | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here. |
||
|
|
||
| - name: Are GPUs recognized by our DL frameworks | ||
| run: | | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will update this after the merge to something cleaner.