Merged
Conversation
Tapas v4 final
Fix comments by @sgugger and @patrickvonplaten
Some minor fixes
Closed
LysandreJik
approved these changes
Dec 15, 2020
Member
LysandreJik
left a comment
LysandreJik
left a comment
There was a problem hiding this comment.
After these changes are applied, LGTM. There are still some comments leftover from the previous PR. Do you want me to take care of it @NielsRogge?
| pip install --upgrade pip | ||
| pip install .[torch,sklearn,testing,onnxruntime,sentencepiece] | ||
| pip install git+https://github.com/huggingface/datasets | ||
| pip install pandas torch-scatter -f https://pytorch-geometric.com/whl/torch-$(python -c "import torch; print(''.join(torch.__version__)")+$(python -c "import torch; print(''.join(torch.version.cuda.split('.')))").html |
Member
There was a problem hiding this comment.
I will update this after the merge to something cleaner.
| pip install --upgrade pip | ||
| pip install .[torch,sklearn,testing,onnxruntime,sentencepiece] | ||
| pip install git+https://github.com/huggingface/datasets | ||
| pip install pandas torch-scatter -f https://pytorch-geometric.com/whl/torch-$(python -c "import torch; print(''.join(torch.__version__)")+$(python -c "import torch; print(''.join(torch.version.cuda.split('.')))").html |
Member
|
Don't worry about the TF tests, these are because of TF2.4 which are fixed on |
Contributor
Author
|
The conversion script currently includes a line in which I'm importing a local |
sgugger
approved these changes
Dec 15, 2020
Co-authored-by: sgugger <sylvain.gugger@gmail.com>
LysandreJik
approved these changes
Dec 15, 2020
Member
LysandreJik
left a comment
LysandreJik
left a comment
There was a problem hiding this comment.
Absolutely incredible work, thank you @NielsRogge for your patience and for your impressive work. Merging!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here we are again, opening a new PR based on the former (#8988) which had some Github issues.
cc @LysandreJik