Skip to content

[ci] skip doc jobs - circleCI is not reliable - disable skip for now #8926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stas00 merged 18 commits into from
Dec 4, 2020
Merged

[ci] skip doc jobs - circleCI is not reliable - disable skip for now #8926

Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
e2111f3
log modified files separately
stas00 Dec 4, 2020
e84fa38
ignore yml while testing
stas00 Dec 4, 2020
234263b
code
stas00 Dec 4, 2020
a127592
doc
stas00 Dec 4, 2020
9e74f38
restore
stas00 Dec 4, 2020
f50a0f4
code + push
stas00 Dec 4, 2020
7a0a8c2
doc + push
stas00 Dec 4, 2020
aafaca9
restore
stas00 Dec 4, 2020
e01758d
code + push
stas00 Dec 4, 2020
6c49f6f
doc + push
stas00 Dec 4, 2020
1b221be
Merge remote-tracking branch 'origin/master' into ci-doc-skip-edge-case
stas00 Dec 4, 2020
2298f52
add failing test
stas00 Dec 4, 2020
5b5799b
doc2 + push
stas00 Dec 4, 2020
93debb5
reset
stas00 Dec 4, 2020
a104ad7
add failing test
stas00 Dec 4, 2020
996c34d
add doc + push with code
stas00 Dec 4, 2020
9a40d4d
revert
stas00 Dec 4, 2020
db02a0f
disable skipping, but leave logging for the future
stas00 Dec 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,14 @@ commands:
# pipeline.git.base_revision is not always defined, so only proceed if all external vars are defined
if test -n "<< pipeline.git.base_revision >>" && test -n "<< pipeline.git.revision >>" && test -n "$(git diff --name-only << pipeline.git.base_revision >>...<< pipeline.git.revision >>)"
then
git diff --name-only << pipeline.git.base_revision >>...<< pipeline.git.revision >>
if git diff --name-only << pipeline.git.base_revision >>...<< pipeline.git.revision >> | egrep -qv '\.(md|rst)$'
then
echo "Non-docs were modified in this PR, proceeding normally"
else
echo "Only docs were modified in this PR, quitting this job"
circleci step halt
# disable skipping for now, as circleCI's base_revision is inconsistent leading to invalid ranges
# circleci step halt
fi
else
echo "Can't perform skipping check w/o base_revision defined, continuing the job"
Expand Down