[ci] skip doc jobs - circleCI is not reliable - disable skip for now #8926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stas00
changed the title
stas00
changed the title
Collaborator
|
Thanks for investigating this! |
Contributor
Author
|
The thread discussing getting a reliable range of changes on CircleCI is here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't do reliable skipping if we can't get a reliable range of changes and cirlcleCI is all over
e.g. in this PR #8918 it changed
pipeline.git.base_revisionon every commit resulting only the changes from last commit appearing as a change for the whole PR, which is very bad, since the PR could be failing tests, but the last commit's changes in doc file only will make it appear that everything is green, which could be very misleading.I wasn't able to reproduce this yet another edge case (see attempts below), but we clearly have that happened in #8918
So this PR disables the magic until I hope I get a solution from circleCI devs which we are discussing via their support.
I'm leaving the printouts in place to continue diagnosing the issue.
It could also be that we won't be able to do that if we don't find a reliable to way to get such a simple information from circleCI, then I will remove it completely.
Thank you for bearing with me, as this is a nice-to-have but not an essential feature.
@LysandreJik, @sgugger