Silence deprecations and use the DataLoaderConfig #29779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacman100
approved these changes
Mar 21, 2024
Contributor
pacman100
left a comment
pacman100
left a comment
There was a problem hiding this comment.
Thank you @muellerzr for refactoring the code to account for the deprecations, LGTM! 🧹✨
muellerzr
commented
Mar 21, 2024
Comment on lines
+4256
to
+4270
| if is_accelerate_available("0.28.0"): | ||
| dataloader_config = DataLoaderConfiguration( | ||
| split_batches=accelerator_config.pop("split_batches"), | ||
| dispatch_batches=accelerator_config.pop("dispatch_batches"), | ||
| even_batches=accelerator_config.pop("even_batches"), | ||
| use_seedable_sampler=accelerator_config.pop("use_seedable_sampler"), | ||
| ) | ||
| args = { | ||
| "deepspeed_plugin": self.args.deepspeed_plugin, | ||
| "gradient_accumulation_plugin": gradient_accumulation_plugin, | ||
| } | ||
| if is_accelerate_available("0.28.0"): | ||
| args["dataloader_config"] = dataloader_config | ||
| else: | ||
| args.update(accelerator_config) |
Contributor
Author
There was a problem hiding this comment.
This design method allows us to be prepared for future versions of accelerator_config where we might want to add more values that don't directly relate to the DataLoaderConfiguration
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
amyeroberts
approved these changes
Mar 21, 2024
Contributor
amyeroberts
left a comment
amyeroberts
left a comment
There was a problem hiding this comment.
Thanks for adding this so quickly! 🔥
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Now that accelerate v0.28.0 is out, removes the super annoying future warnings and opts to use the
DataLoaderConfigFollow up to #28664
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@pacman100 @amyeroberts