-
Notifications
You must be signed in to change notification settings - Fork 31.6k
Introduce AcceleratorConfig dataclass #28664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2212a58 to
9b95001
Compare
|
@amyeroberts tests finally pass after losing my mind on imports 🙌 |
amyeroberts
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this! I can see that it's really going to help understand the arguments and handle them in the code.
amyeroberts
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating - looking good!
Just a few final comments
|
Hi @muellerzr , could you please get this PR merged? We need the PR to get the accelerate test on TPU v3 to succeed again. Thanks. |
2c60474 to
c99d51c
Compare
|
As a general note, immediately after the next accelerate release I'll make a follow-up PR utilizing the config class seen here so users won't have annoying FutureWarning's huggingface/accelerate#2441 (No big logic difference, just shove it all into the config rather than the Accelerator based on the accelerate version) |
amyeroberts
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for iterating!
|
For the doc tests, there was a recent commit merged to main, which should hopefully resolve this. |
Co-authored-by: amyeroberts <[email protected]>
Co-authored-by: amyeroberts <[email protected]>
8c9535a to
1de6ff5
Compare
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
devCaiquedePaula
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docstring for the AcceleratorConfig class is clear and provides a brief description of its purpose. Consider adding information about each attribute's meaning and potential values to make it more informative.
What does this PR do?
This PR centralizes all arguments for the
Acceleratornot covered byfsdp_configanddeepspeed_configinto a singular dataclass that users can pass in as a json file or through raw CLI param args.I think I have the CLI args configured right? But I'm not 100% sure. Advice on how to check that would be appreciated!
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@amyeroberts @LysandreJik