Update test reqs to include sentencepiece #29756
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Hi, noticed our tests on our PR CI for Accelerate have been red for a week, due to #29675
Specifically, before most of the tests in
test_trainer_seq2seqwere marked asslowso they were being skipped on our normal CI. However now that it's unslow for once, these tests requiresentencepiece.I've added two different options for this:
require_sentencepiecedecorator, else we get an err:sentencepieceas a test dep, to allow forpip install -e .[torch,testing]to work fine and minimize downstream impactBefore submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
cc @amyeroberts