Trainer: fail early in the presence of an unsavable generation_config
#29675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gante
changed the title
generation_configgeneration_config
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
amyeroberts
approved these changes
Mar 15, 2024
Contributor
amyeroberts
left a comment
amyeroberts
left a comment
There was a problem hiding this comment.
Thanks for quickly adding this!
| with warnings.catch_warnings(record=True) as caught_warnings: | ||
| gen_config.validate() | ||
| if len(caught_warnings) > 0: | ||
| raise ValueError(str([w.message for w in caught_warnings])) |
Contributor
There was a problem hiding this comment.
Will this properly separate out the messages? We might want to add a line break in between the w.message elements
Contributor
Author
There was a problem hiding this comment.
Yes, it prints a list of str, so it is easy to separate the messages :)
a = ["foo", "bar", "baz"]
raise ValueError(str([msg for msg in a]))
# ValueError: ['foo', 'bar', 'baz']
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #29665
We don't allow saving bad generation config files (i.e. ones whose validation has warnings or exceptions). This check was only done at save time, which happens AFTER training. This PR introduces the same check in the trainer's
__init__, to fail early (and before spending time/$)