[test] add CI workflow for VCS installation#22701
Conversation
ebd03ad to
f0daff5
Compare
5ea0d5c to
2ba9a42
Compare
2ba9a42 to
14a9ea6
Compare
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
9a17987 to
4bf1a88
Compare
4bf1a88 to
be23fce
Compare
|
|
||
| jobs: | ||
| check-vcs-installation: | ||
| runs-on: ubuntu-20.04 # the oldest Ubuntu LTS version |
There was a problem hiding this comment.
Maybe also add test for macOS and Windows. But I think it would be unnecessary. The wheel for transformers is platform-independent (the dependencies are platform-dependent).
|
Or we can just leave the setup as is and there won't be any need for this new check :-) |
The CI workflows in this PR can also benefit to check the viability of I think the ultimate solution is to ask the user to upgrade their pip install --upgrade pip setuptools # upgrade to support PEP 660
pip install git+https://github.com/huggingface/transformers |
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
What does this PR do?
Add a CI test for checking VCS installation (via URL or git repo). This workflow prevents potential breakage for install from source installation method.
Ref:
pyproject.toml#22539Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.