[setup] migrate setup script to pyproject.toml#22539
Merged
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
reviewed
Apr 3, 2023
sgugger
left a comment
sgugger
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for your PR. Will double check that the package data keeps to be included. Other than that flagged one difference.
| long_description=open("README.md", "r", encoding="utf-8").read(), | ||
| long_description_content_type="text/markdown", |
Collaborator
There was a problem hiding this comment.
We are losing those apparently.
Contributor
Author
There was a problem hiding this comment.
It goes to project.readme in pyproject.toml. The content type will be inferred from the extension (.md or .rst).
sgugger
approved these changes
Apr 3, 2023
sgugger
left a comment
sgugger
left a comment
Collaborator
There was a problem hiding this comment.
Tested locally and can confirm all extra files are still included in the build. Thanks for your PR!
raghavanone
pushed a commit
to raghavanone/transformers
that referenced
this pull request
Apr 5, 2023
* [setup] migrate setup script to `pyproject.toml` * [setup] cleanup configurations * remove unused imports
4 tasks
5 tasks
novice03
pushed a commit
to novice03/transformers
that referenced
this pull request
Jun 23, 2023
* [setup] migrate setup script to `pyproject.toml` * [setup] cleanup configurations * remove unused imports
5 tasks
XuehaiPan
added a commit
to XuehaiPan/transformers
that referenced
this pull request
Dec 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follows discussion in #22531 (comment)
Changes:
pyproject.tomlpytestconfigs topyproject.tomlisortandflake8configsBefore submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.