Use config.num_channels in CLIP-like modeling files
#20857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
LysandreJik
approved these changes
Dec 21, 2022
Member
LysandreJik
left a comment
LysandreJik
left a comment
There was a problem hiding this comment.
Sounds good to me, I checked on the Hub and couldn't find any model that uses config.num_channels != 3.
MKhalusova
pushed a commit
to MKhalusova/transformers
that referenced
this pull request
Dec 28, 2022
) Use config.num_channels in CLIP-like modeling files Co-authored-by: ydshieh <[email protected]>
silverriver
pushed a commit
to silverriver/transformers
that referenced
this pull request
Jan 6, 2023
) Use config.num_channels in CLIP-like modeling files Co-authored-by: ydshieh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
config.num_channelsis not used in some CLIP-like modeling files. Unlike previous PRs like #20596 or #20844, we use this attribute in the modeling files in this PR.The only breaking case is when a user previously set
config.num_channels=XwithX !=3, which is super unlikely IMO. (Even they did so, the actual Conv2D layer still uses3as it is hard-coded in the currentmainbranch)